From: Arnd Bergmann <arnd@arndb.de>
To: linaro-acpi@lists.linaro.org
Cc: Timur Tabi <timur@codeaurora.org>,
Wim Van Sebroeck <wim@iguana.be>,
Vipul Gandhi <vgandhi@codeaurora.org>,
linux-watchdog@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [Linaro-acpi] [PATCH] [v2] watchdog: introduce the ARM64 SBSA watchdog driver
Date: Fri, 15 May 2015 20:57:45 +0200 [thread overview]
Message-ID: <6745558.xPJvXDnxj5@wuerfel> (raw)
In-Reply-To: <55561CF1.9090308@codeaurora.org>
On Friday 15 May 2015 11:21:05 Timur Tabi wrote:
> On 05/15/2015 08:20 AM, Arnd Bergmann wrote:
>
> > Do you get a sparse warning if you either leave the __le32, or if you
> > turn it into u32?
>
> After removing the cpu_to_le32 calls, but keeping the __le32 in the
> structs, I get no sparse warnings on my driver.
Ok, good. I've also checked the readl() definition and found that it
has a (__force __le32) cast, while __raw_readl() takes a const volatile
void __iomem *addr) pointer, so it sparse won't warn either way, but
that's probably ok.
Arnd
prev parent reply other threads:[~2015-05-15 18:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 16:52 [PATCH] [v2] watchdog: introduce the ARM64 SBSA watchdog driver Timur Tabi
2015-05-14 20:03 ` Arnd Bergmann
2015-05-14 20:15 ` Timur Tabi
2015-05-14 20:45 ` Guenter Roeck
2015-05-14 21:03 ` Timur Tabi
2015-05-14 23:41 ` Guenter Roeck
2015-05-14 23:49 ` Timur Tabi
2015-05-15 9:16 ` Arnd Bergmann
2015-05-15 12:14 ` Timur Tabi
2015-05-15 13:20 ` [Linaro-acpi] " Arnd Bergmann
2015-05-15 16:21 ` Timur Tabi
2015-05-15 18:57 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6745558.xPJvXDnxj5@wuerfel \
--to=arnd@arndb.de \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=timur@codeaurora.org \
--cc=vgandhi@codeaurora.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox