* [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api [not found] <1329474800-20979-1-git-send-email-blogic@openwrt.org> @ 2012-02-17 10:33 ` John Crispin 2012-02-17 17:40 ` Sergei Shtylyov 0 siblings, 1 reply; 3+ messages in thread From: John Crispin @ 2012-02-17 10:33 UTC (permalink / raw) To: Ralf Baechle; +Cc: linux-mips, John Crispin, linux-watchdog Update from old pmu_{dis,en}able() to ckldev api. Signed-off-by: John Crispin <blogic@openwrt.org> Cc: linux-watchdog@vger.kernel.org --- This patch should go via MIPS with the rest of the series. drivers/watchdog/lantiq_wdt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/watchdog/lantiq_wdt.c b/drivers/watchdog/lantiq_wdt.c index 9c8b10c..05646b8 100644 --- a/drivers/watchdog/lantiq_wdt.c +++ b/drivers/watchdog/lantiq_wdt.c @@ -206,7 +206,7 @@ ltq_wdt_probe(struct platform_device *pdev) } /* we do not need to enable the clock as it is always running */ - clk = clk_get(&pdev->dev, "io"); + clk = clk_get_sys("io", NULL); WARN_ON(!clk); ltq_io_region_clk_rate = clk_get_rate(clk); clk_put(clk); -- 1.7.7.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api 2012-02-17 10:33 ` [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api John Crispin @ 2012-02-17 17:40 ` Sergei Shtylyov 2012-02-17 16:47 ` John Crispin 0 siblings, 1 reply; 3+ messages in thread From: Sergei Shtylyov @ 2012-02-17 17:40 UTC (permalink / raw) To: John Crispin; +Cc: Ralf Baechle, linux-mips, linux-watchdog Hello. On 02/17/2012 01:33 PM, John Crispin wrote: > Update from old pmu_{dis,en}able() to ckldev api. Again, you're doing something different. > Signed-off-by: John Crispin<blogic@openwrt.org> > Cc: linux-watchdog@vger.kernel.org > --- > This patch should go via MIPS with the rest of the series. > > drivers/watchdog/lantiq_wdt.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/watchdog/lantiq_wdt.c b/drivers/watchdog/lantiq_wdt.c > index 9c8b10c..05646b8 100644 > --- a/drivers/watchdog/lantiq_wdt.c > +++ b/drivers/watchdog/lantiq_wdt.c > @@ -206,7 +206,7 @@ ltq_wdt_probe(struct platform_device *pdev) > } > > /* we do not need to enable the clock as it is always running */ > - clk = clk_get(&pdev->dev, "io"); > + clk = clk_get_sys("io", NULL); Why not clk_get(&pdev->dev, NULL)? WBR, Sergei ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api 2012-02-17 17:40 ` Sergei Shtylyov @ 2012-02-17 16:47 ` John Crispin 0 siblings, 0 replies; 3+ messages in thread From: John Crispin @ 2012-02-17 16:47 UTC (permalink / raw) To: Sergei Shtylyov; +Cc: Ralf Baechle, linux-mips, linux-watchdog Hi Sergei, > ( The comment doesn't match the essence of patch. ) > Again, you're doing something different. > sorry > Why not clk_get(&pdev->dev, NULL)? > > WBR, Sergei > > clk_get_sys uses the clkdev lookup table, which is added by this series. it makes the clock code consistent throughout the lantiq related files. we use clk connections other places, which we cannot reference with clk_get that easily John ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-17 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1329474800-20979-1-git-send-email-blogic@openwrt.org>
2012-02-17 10:33 ` [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api John Crispin
2012-02-17 17:40 ` Sergei Shtylyov
2012-02-17 16:47 ` John Crispin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).