* [PATCH 0/3] replace del_timer by del_timer_sync
@ 2014-04-01 13:49 Julia Lawall
2014-04-01 13:49 ` [PATCH 3/3] watchdog: via_wdt: " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2014-04-01 13:49 UTC (permalink / raw)
To: netdev; +Cc: kernel-janitors, linux-wireless, linux-kernel, linux-watchdog
These patches replace del_timer by del_timer_sync in remove functions.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync
2014-04-01 13:49 [PATCH 0/3] replace del_timer by del_timer_sync Julia Lawall
@ 2014-04-01 13:49 ` Julia Lawall
2014-04-02 14:08 ` Guenter Roeck
2014-05-26 18:49 ` Wim Van Sebroeck
0 siblings, 2 replies; 4+ messages in thread
From: Julia Lawall @ 2014-04-01 13:49 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: kernel-janitors, linux-watchdog, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Use del_timer_sync to ensure that the timer is stopped on all CPUs before
the driver exits.
This change was suggested by Thomas Gleixner.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier i,t,ex;
@@
struct t i = { .remove = ex, };
@@
identifier r.ex;
@@
ex(...) {
<...
- del_timer
+ del_timer_sync
(...)
...>
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Not tested.
drivers/watchdog/via_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
index d2cd9f0..56369c4 100644
--- a/drivers/watchdog/via_wdt.c
+++ b/drivers/watchdog/via_wdt.c
@@ -232,7 +232,7 @@ err_out_disable_device:
static void wdt_remove(struct pci_dev *pdev)
{
watchdog_unregister_device(&wdt_dev);
- del_timer(&timer);
+ del_timer_sync(&timer);
iounmap(wdt_mem);
release_mem_region(mmio, VIA_WDT_MMIO_LEN);
release_resource(&wdt_res);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync
2014-04-01 13:49 ` [PATCH 3/3] watchdog: via_wdt: " Julia Lawall
@ 2014-04-02 14:08 ` Guenter Roeck
2014-05-26 18:49 ` Wim Van Sebroeck
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2014-04-02 14:08 UTC (permalink / raw)
To: Julia Lawall, Wim Van Sebroeck
Cc: kernel-janitors, linux-watchdog, linux-kernel
On 04/01/2014 06:49 AM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Use del_timer_sync to ensure that the timer is stopped on all CPUs before
> the driver exits.
>
> This change was suggested by Thomas Gleixner.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier i,t,ex;
> @@
> struct t i = { .remove = ex, };
>
> @@
> identifier r.ex;
> @@
> ex(...) {
> <...
> - del_timer
> + del_timer_sync
> (...)
> ...>
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync
2014-04-01 13:49 ` [PATCH 3/3] watchdog: via_wdt: " Julia Lawall
2014-04-02 14:08 ` Guenter Roeck
@ 2014-05-26 18:49 ` Wim Van Sebroeck
1 sibling, 0 replies; 4+ messages in thread
From: Wim Van Sebroeck @ 2014-05-26 18:49 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, linux-watchdog, linux-kernel
Hi Julia,
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Use del_timer_sync to ensure that the timer is stopped on all CPUs before
> the driver exits.
>
> This change was suggested by Thomas Gleixner.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier i,t,ex;
> @@
> struct t i = { .remove = ex, };
>
> @@
> identifier r.ex;
> @@
> ex(...) {
> <...
> - del_timer
> + del_timer_sync
> (...)
> ...>
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Not tested.
>
> drivers/watchdog/via_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
> index d2cd9f0..56369c4 100644
> --- a/drivers/watchdog/via_wdt.c
> +++ b/drivers/watchdog/via_wdt.c
> @@ -232,7 +232,7 @@ err_out_disable_device:
> static void wdt_remove(struct pci_dev *pdev)
> {
> watchdog_unregister_device(&wdt_dev);
> - del_timer(&timer);
> + del_timer_sync(&timer);
> iounmap(wdt_mem);
> release_mem_region(mmio, VIA_WDT_MMIO_LEN);
> release_resource(&wdt_res);
>
This was added 2 or 3 weeks ago to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-26 18:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-01 13:49 [PATCH 0/3] replace del_timer by del_timer_sync Julia Lawall
2014-04-01 13:49 ` [PATCH 3/3] watchdog: via_wdt: " Julia Lawall
2014-04-02 14:08 ` Guenter Roeck
2014-05-26 18:49 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox