From: Guenter Roeck <linux@roeck-us.net>
To: Vladimir Zapolskiy <vz@mleia.com>, Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: pnx4008: make global wdt_clk static
Date: Mon, 2 Nov 2015 06:34:07 -0800 [thread overview]
Message-ID: <5637745F.8080007@roeck-us.net> (raw)
In-Reply-To: <1445993735-7817-1-git-send-email-vz@mleia.com>
On 10/27/2015 05:55 PM, Vladimir Zapolskiy wrote:
> Silences sparse warning:
>
> drivers/watchdog/pnx4008_wdt.c:83:25:
> warning: symbol 'wdt_clk' was not declared. Should it be static?
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/pnx4008_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c
> index 4224b3e..a8ade06 100644
> --- a/drivers/watchdog/pnx4008_wdt.c
> +++ b/drivers/watchdog/pnx4008_wdt.c
> @@ -80,7 +80,7 @@ static unsigned int heartbeat = DEFAULT_HEARTBEAT;
>
> static DEFINE_SPINLOCK(io_lock);
> static void __iomem *wdt_base;
> -struct clk *wdt_clk;
> +static struct clk *wdt_clk;
>
> static int pnx4008_wdt_start(struct watchdog_device *wdd)
> {
>
prev parent reply other threads:[~2015-11-02 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 0:55 [PATCH] watchdog: pnx4008: make global wdt_clk static Vladimir Zapolskiy
2015-11-02 14:34 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5637745F.8080007@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=vz@mleia.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox