* [PATCH] watchdog: pnx4008: make global wdt_clk static
@ 2015-10-28 0:55 Vladimir Zapolskiy
2015-11-02 14:34 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Zapolskiy @ 2015-10-28 0:55 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-watchdog
Silences sparse warning:
drivers/watchdog/pnx4008_wdt.c:83:25:
warning: symbol 'wdt_clk' was not declared. Should it be static?
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
drivers/watchdog/pnx4008_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c
index 4224b3e..a8ade06 100644
--- a/drivers/watchdog/pnx4008_wdt.c
+++ b/drivers/watchdog/pnx4008_wdt.c
@@ -80,7 +80,7 @@ static unsigned int heartbeat = DEFAULT_HEARTBEAT;
static DEFINE_SPINLOCK(io_lock);
static void __iomem *wdt_base;
-struct clk *wdt_clk;
+static struct clk *wdt_clk;
static int pnx4008_wdt_start(struct watchdog_device *wdd)
{
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: pnx4008: make global wdt_clk static
2015-10-28 0:55 [PATCH] watchdog: pnx4008: make global wdt_clk static Vladimir Zapolskiy
@ 2015-11-02 14:34 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2015-11-02 14:34 UTC (permalink / raw)
To: Vladimir Zapolskiy, Wim Van Sebroeck; +Cc: linux-watchdog
On 10/27/2015 05:55 PM, Vladimir Zapolskiy wrote:
> Silences sparse warning:
>
> drivers/watchdog/pnx4008_wdt.c:83:25:
> warning: symbol 'wdt_clk' was not declared. Should it be static?
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/pnx4008_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c
> index 4224b3e..a8ade06 100644
> --- a/drivers/watchdog/pnx4008_wdt.c
> +++ b/drivers/watchdog/pnx4008_wdt.c
> @@ -80,7 +80,7 @@ static unsigned int heartbeat = DEFAULT_HEARTBEAT;
>
> static DEFINE_SPINLOCK(io_lock);
> static void __iomem *wdt_base;
> -struct clk *wdt_clk;
> +static struct clk *wdt_clk;
>
> static int pnx4008_wdt_start(struct watchdog_device *wdd)
> {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-02 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-28 0:55 [PATCH] watchdog: pnx4008: make global wdt_clk static Vladimir Zapolskiy
2015-11-02 14:34 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox