From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Sam Protsenko <semen.protsenko@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 11/12] watchdog: s3c2410: Remove superfluous err label
Date: Tue, 2 Nov 2021 11:17:00 +0100 [thread overview]
Message-ID: <645dbbca-eddb-52e6-5f7a-9eeb819e85a6@canonical.com> (raw)
In-Reply-To: <20211031122216.30212-12-semen.protsenko@linaro.org>
On 31/10/2021 13:22, Sam Protsenko wrote:
> 'err' label in probe function is not really need, it just returns.
> Remove it and replace all 'goto' statements with actual returns in
> place.
>
> No functional change here, just a cleanup patch.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> Changes in v2:
> - (none): it's a new patch
>
> drivers/watchdog/s3c2410_wdt.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-11-02 10:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 12:22 [PATCH v2 00/12] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-10-31 12:22 ` [PATCH v2 01/12] dt-bindings: watchdog: Require samsung,syscon-phandle for Exynos7 Sam Protsenko
2021-11-01 19:21 ` Rob Herring
2021-10-31 12:22 ` [PATCH v2 02/12] dt-bindings: watchdog: Document Exynos850 watchdog bindings Sam Protsenko
2021-11-02 9:46 ` Krzysztof Kozlowski
2021-10-31 12:22 ` [PATCH v2 03/12] watchdog: s3c2410: Fail probe if can't find valid timeout Sam Protsenko
2021-11-02 9:49 ` Krzysztof Kozlowski
2021-10-31 12:22 ` [PATCH v2 04/12] watchdog: s3c2410: Let kernel kick watchdog Sam Protsenko
2021-11-02 9:49 ` Krzysztof Kozlowski
2021-10-31 12:22 ` [PATCH v2 05/12] watchdog: s3c2410: Make reset disable register optional Sam Protsenko
2021-11-02 9:52 ` Krzysztof Kozlowski
2021-10-31 12:22 ` [PATCH v2 06/12] watchdog: s3c2410: Extract disable and mask code into separate functions Sam Protsenko
2021-11-02 9:55 ` Krzysztof Kozlowski
2021-10-31 12:22 ` [PATCH v2 07/12] watchdog: s3c2410: Implement a way to invert mask reg value Sam Protsenko
2021-11-02 10:17 ` Krzysztof Kozlowski
2021-10-31 12:22 ` [PATCH v2 08/12] watchdog: s3c2410: Add support for WDT counter enable register Sam Protsenko
2021-11-02 10:05 ` Krzysztof Kozlowski
2021-10-31 12:22 ` [PATCH v2 09/12] watchdog: s3c2410: Cleanup PMU related code Sam Protsenko
2021-11-02 10:12 ` Krzysztof Kozlowski
2021-10-31 12:22 ` [PATCH v2 10/12] watchdog: s3c2410: Support separate source clock Sam Protsenko
2021-11-02 10:15 ` Krzysztof Kozlowski
2021-11-07 15:55 ` Sam Protsenko
2021-11-07 16:09 ` Guenter Roeck
2021-11-07 18:51 ` Sam Protsenko
2021-11-07 19:01 ` Guenter Roeck
2021-10-31 12:22 ` [PATCH v2 11/12] watchdog: s3c2410: Remove superfluous err label Sam Protsenko
2021-11-02 10:17 ` Krzysztof Kozlowski [this message]
2021-10-31 12:22 ` [PATCH v2 12/12] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-10-31 15:15 ` kernel test robot
2021-10-31 16:09 ` kernel test robot
2021-11-02 10:26 ` Krzysztof Kozlowski
2021-11-07 16:17 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645dbbca-eddb-52e6-5f7a-9eeb819e85a6@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox