Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Linus Walleij <linusw@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Justin Chen <justin.chen@broadcom.com>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: bcm7038: Add a restart callback
Date: Wed, 14 Oct 2026 15:52:23 -0700	[thread overview]
Message-ID: <76ae9a74-7ea2-404f-b933-80ae29d113c4@broadcom.com> (raw)
In-Reply-To: <20261015-genexis-xg6846-watchdog-reset-v1-1-9577d65223d5@kernel.org>

+CC Justin,

On 10/14/26 15:39, Linus Walleij wrote:
> The watchdog in BCM6846 can reset the system, but bcm7038_wdt
> does not provide a restart callback. Add this.
> 
> The vendor kernel also uses a short watchdog timeout to reset
> this SoC.
> 
> Implement the restart operation by stopping the watchdog, loading the
> minimum count of two ticks and starting it again. A count below two
> does not trigger a reset, as also documented by the U-Boot BCM6345
> watchdog driver.
> 
> Disable local interrupts across the register sequence and
> reset wait  so preemptible uniprocessor MIPS kernels cannot run
> a competing watchdog operation.
> 
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>

We could also implement the .bootstatus callback by reading the WDCR 
register at offset 0x10 and check for bit 0 being set to indicate a 
watchdog reset or not.
-- 
Florian

  parent reply	other threads:[~2026-10-14 22:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 22:39 [PATCH] watchdog: bcm7038: Add a restart callback Linus Walleij
2026-10-14 22:48 ` sashiko-bot
2026-10-14 22:52 ` Florian Fainelli [this message]
2026-10-15 19:30 ` Justin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76ae9a74-7ea2-404f-b933-80ae29d113c4@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=justin.chen@broadcom.com \
    --cc=linusw@kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox