Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Heyi Guo <guoheyi@linux.alibaba.com>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org,  linux-kernel@vger.kernel.org,
	linux-watchdog@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: aspeed-g6.dtsi: enable IRQ for watchdogs
Date: Wed, 19 Feb 2025 11:42:51 +1030	[thread overview]
Message-ID: <a7df160add1563a69573e00af44caf8bb73f520b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250218031709.103823-2-guoheyi@linux.alibaba.com>

Hi Heyi,

On Tue, 2025-02-18 at 11:16 +0800, Heyi Guo wrote:
> To finally enable watchdog pretimeout function.
> 
> Signed-off-by: Heyi Guo <guoheyi@linux.alibaba.com>
> 
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Andrew Jeffery <andrew@codeconstruct.com.au>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> index 8ed715bd53aa..ef7ced285c44 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> @@ -538,23 +538,27 @@ uart5: serial@1e784000 {
>                         wdt1: watchdog@1e785000 {
>                                 compatible = "aspeed,ast2600-wdt";
>                                 reg = <0x1e785000 0x40>;
> +                               interrupts = <GIC_SPI 24
> IRQ_TYPE_LEVEL_HIGH>;

The binding will need an update to allow 'interrupts' as an optional
property.

Andrew

  parent reply	other threads:[~2025-02-19  1:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18  3:16 [PATCH 1/2] driver/aspeed-wdt: fix pretimeout for counting down logic Heyi Guo
2025-02-18  3:16 ` [PATCH 2/2] ARM: dts: aspeed: aspeed-g6.dtsi: enable IRQ for watchdogs Heyi Guo
2025-02-18  7:53   ` Krzysztof Kozlowski
2025-02-19  1:12   ` Andrew Jeffery [this message]
2025-02-18  5:33 ` [PATCH 1/2] driver/aspeed-wdt: fix pretimeout for counting down logic Guenter Roeck
2025-02-19  1:25   ` Andrew Jeffery
2025-02-19  1:40     ` Guenter Roeck
2025-02-19  3:41   ` Heyi Guo
2025-02-19  6:07     ` Guenter Roeck
2025-02-19  6:48       ` Heyi Guo
     [not found]   ` <7e2c5f2c-d07a-472c-aae5-6b639a144d88@linux.alibaba.com>
2025-02-19  3:51     ` Heyi Guo
2025-02-19  0:42 ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7df160add1563a69573e00af44caf8bb73f520b.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guoheyi@linux.alibaba.com \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox