Linux wireless drivers development
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Cc: Markus Theil <markus.theil@tu-ilmenau.de>
Subject: Re: [PATCH 1/2] Revert "mac80211: support NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_MAC_ADDRS"
Date: Mon, 24 Feb 2020 12:57:14 -0600	[thread overview]
Message-ID: <048b81db-8e92-7fe0-1f5c-3b6f9ea1a1f1@gmail.com> (raw)
In-Reply-To: <1a56c641eaa03c99dc9a90208902d8bb1ca1b0aa.camel@sipsolutions.net>

Hi Johannes,

> That's a question of how you define "special data packet processing"...
> You're defining it purely in terms of the mechanics of how you handle
> them, but that's not really the point.

Why isn't it the point?  These are the only data packets userspace 
management daemon(s) actually care about and has to setup raw sockets + 
bpf filters for every interface it manages.  The current control port 
makes all of that unnecessary.

So from a holistic point of view, taking kernel + userspace into 
account, what is wrong with letting control port transport preauth 
frames if that saves a bunch of resources (and possibly wakeups if the 
bpf is setup badly) on the system?

Also, the question is what changed your mind?  I asked you specifically 
if preauth should be included in the control port API and you thought it 
was a good idea at the time?

> 
> Preauth frames are _not_ special. They're entirely regular data packets
> as far as wifi is concerned.

Sure.  I already conceded this point if this wasn't clear earlier.

Regards,
-Denis

  reply	other threads:[~2020-02-24 19:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24  9:19 [PATCH 1/2] Revert "mac80211: support NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_MAC_ADDRS" Johannes Berg
2020-02-24  9:19 ` [PATCH 2/2] Revert "nl80211: add src and dst addr attributes for control port tx/rx" Johannes Berg
2020-02-24 16:56 ` [PATCH 1/2] Revert "mac80211: support NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_MAC_ADDRS" Denis Kenzior
2020-02-24 18:26   ` Johannes Berg
2020-02-24 18:26     ` Denis Kenzior
2020-02-24 18:47       ` Johannes Berg
2020-02-24 18:57         ` Denis Kenzior [this message]
2020-02-24 19:34           ` Johannes Berg
2020-02-24 19:35             ` Denis Kenzior
2020-02-25 11:00               ` Jouni Malinen
2020-02-25 17:06                 ` Denis Kenzior
2020-03-04 16:24                   ` Markus Theil
2020-03-11  9:31                     ` Johannes Berg
2020-03-11  9:36                       ` Markus Theil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=048b81db-8e92-7fe0-1f5c-3b6f9ea1a1f1@gmail.com \
    --to=denkenz@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=markus.theil@tu-ilmenau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox