From: Denis Kenzior <denkenz@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Markus Theil <markus.theil@tu-ilmenau.de>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 1/2] Revert "mac80211: support NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_MAC_ADDRS"
Date: Mon, 24 Feb 2020 10:56:43 -0600 [thread overview]
Message-ID: <c9fba32a-6959-a93a-3119-23915053538c@gmail.com> (raw)
In-Reply-To: <20200224101910.b87da63a3cd6.Ic94bc51a370c4aa7d19fbca9b96d90ab703257dc@changeid>
Hi Johannes,
On 2/24/20 3:19 AM, Johannes Berg wrote:
> As Jouni points out, there's really no need for this, since the
> RSN pre-authentication frames are normal data frames, not port
> control frames (locally).
Using control port for pre-auth frame TX/RX allows userspace to skip
setting up a raw socket and associated bpf filters. This greatly
simplifies the rx/tx path and uses less resources as well.
So to me this patch set seemed like a good idea... We (iwd) don't have
plans to support pre-auth in AP mode in the near future, so this revert
doesn't really affect us. I do wonder what is the actual concern to
warrant a revert?
Regards,
-Denis
next prev parent reply other threads:[~2020-02-24 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 9:19 [PATCH 1/2] Revert "mac80211: support NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_MAC_ADDRS" Johannes Berg
2020-02-24 9:19 ` [PATCH 2/2] Revert "nl80211: add src and dst addr attributes for control port tx/rx" Johannes Berg
2020-02-24 16:56 ` Denis Kenzior [this message]
2020-02-24 18:26 ` [PATCH 1/2] Revert "mac80211: support NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_MAC_ADDRS" Johannes Berg
2020-02-24 18:26 ` Denis Kenzior
2020-02-24 18:47 ` Johannes Berg
2020-02-24 18:57 ` Denis Kenzior
2020-02-24 19:34 ` Johannes Berg
2020-02-24 19:35 ` Denis Kenzior
2020-02-25 11:00 ` Jouni Malinen
2020-02-25 17:06 ` Denis Kenzior
2020-03-04 16:24 ` Markus Theil
2020-03-11 9:31 ` Johannes Berg
2020-03-11 9:36 ` Markus Theil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9fba32a-6959-a93a-3119-23915053538c@gmail.com \
--to=denkenz@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=markus.theil@tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox