From: Johannes Berg <johannes@sipsolutions.net>
To: Tristan Madani <tristmd@gmail.com>,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/3] wifi: wcn36xx: fix heap overflow from oversized firmware HAL response
Date: Thu, 16 Apr 2026 08:38:50 +0200 [thread overview]
Message-ID: <0aa3ac54dd3441cc69e9d58738498e0b72647dc0.camel@sipsolutions.net> (raw)
In-Reply-To: <20260415223710.1616925-2-tristmd@gmail.com> (sfid-20260416_003714_987241_61E10900)
Hi Tristan,
On Wed, 2026-04-15 at 22:37 +0000, Tristan Madani wrote:
> From: Tristan Madani <tristan@talencesecurity.com>
>
> The firmware response dispatcher copies all synchronous HAL responses
> into the 4096-byte hal_buf without validating the response length. A
> response exceeding WCN36XX_HAL_BUF_SIZE causes a heap buffer overflow
> with firmware-controlled content.
>
> Add a bounds check on the response length.
No real problem with these patches etc., but it seems implausible that
you're not using some kind of tool/LLM assistance, which you're supposed
to disclose (or at least I guess I'm supposed to ask you to):
https://docs.kernel.org/process/coding-assistants.html
johannes
next prev parent reply other threads:[~2026-04-16 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 22:37 [PATCH v2 0/3] wifi: wcn36xx: fix OOB reads and heap overflow from firmware responses Tristan Madani
2026-04-15 22:37 ` [PATCH v2 1/3] wifi: wcn36xx: fix heap overflow from oversized firmware HAL response Tristan Madani
2026-04-16 6:38 ` Johannes Berg [this message]
2026-04-15 22:37 ` [PATCH v2 2/3] wifi: wcn36xx: fix OOB read from firmware count in PRINT_REG_INFO indication Tristan Madani
2026-04-15 22:37 ` [PATCH v2 3/3] wifi: wcn36xx: fix OOB read from short trigger BA firmware response Tristan Madani
2026-04-16 16:25 ` [PATCH v2 0/3] wifi: wcn36xx: fix OOB reads and heap overflow from firmware responses Jeff Johnson
2026-04-16 18:39 ` Johannes Berg
2026-04-16 19:50 ` Loic Poulain
2026-04-17 0:01 ` Jeff Johnson
2026-04-17 8:24 ` Loic Poulain
-- strict thread matches above, loose matches on Subject: below --
2026-04-15 22:23 Tristan Madani
2026-04-15 22:23 ` [PATCH v2 1/3] wifi: wcn36xx: fix heap overflow from oversized firmware HAL response Tristan Madani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aa3ac54dd3441cc69e9d58738498e0b72647dc0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=tristmd@gmail.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox