From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Tristan Madani <tristmd@gmail.com>,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 0/3] wifi: wcn36xx: fix OOB reads and heap overflow from firmware responses
Date: Thu, 16 Apr 2026 20:39:36 +0200 [thread overview]
Message-ID: <c29bf32b7f1195a69d86b4f728ab02523675b41b.camel@sipsolutions.net> (raw)
In-Reply-To: <9fa651dd-6004-42c6-8c03-95247d5807fd@oss.qualcomm.com>
On Thu, 2026-04-16 at 09:25 -0700, Jeff Johnson wrote:
> On 4/15/2026 3:37 PM, Tristan Madani wrote:
> > From: Tristan Madani <tristan@talencesecurity.com>
> >
> > Hi Loic,
> >
> > Note: this is a v2 resubmission. The original was sent via Gmail which
> > caused HTML rendering issues. This version uses git send-email for
> > proper plain-text formatting.
> >
> > Three issues in wcn36xx HAL firmware response handling, including a heap
> > overflow in the main response dispatcher:
> >
> > Proposed fixes in the following patches.
> >
> > Thanks,
> > Tristan
>
> Are you able to cause these issues to occur?
> My expectation is that this is testing things that firmware will never do, and
> hence this adds code and processing with no actual benefit.
We're not really supposed to completely trust firmware though, right? :)
johannes
next prev parent reply other threads:[~2026-04-16 18:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 22:37 [PATCH v2 0/3] wifi: wcn36xx: fix OOB reads and heap overflow from firmware responses Tristan Madani
2026-04-15 22:37 ` [PATCH v2 1/3] wifi: wcn36xx: fix heap overflow from oversized firmware HAL response Tristan Madani
2026-04-16 6:38 ` Johannes Berg
2026-04-15 22:37 ` [PATCH v2 2/3] wifi: wcn36xx: fix OOB read from firmware count in PRINT_REG_INFO indication Tristan Madani
2026-04-15 22:37 ` [PATCH v2 3/3] wifi: wcn36xx: fix OOB read from short trigger BA firmware response Tristan Madani
2026-04-16 16:25 ` [PATCH v2 0/3] wifi: wcn36xx: fix OOB reads and heap overflow from firmware responses Jeff Johnson
2026-04-16 18:39 ` Johannes Berg [this message]
2026-04-16 19:50 ` Loic Poulain
2026-04-17 0:01 ` Jeff Johnson
2026-04-17 8:24 ` Loic Poulain
-- strict thread matches above, loose matches on Subject: below --
2026-04-15 22:23 Tristan Madani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c29bf32b7f1195a69d86b4f728ab02523675b41b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=tristmd@gmail.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox