public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: linux-wireless@vger.kernel.org
Cc: kyan@google.com, toke@redhat.com, johannes@sipsolutions.net,
	lorenzo.bianconi@redhat.com
Subject: [PATCH mac80211-next] mac80211: introduce aql_enable node in debugfs
Date: Sat, 26 Dec 2020 10:49:18 +0100	[thread overview]
Message-ID: <0ad278def3875fc2c60b4898daa3f0d53288c168.1608975795.git.lorenzo@kernel.org> (raw)

Introduce aql_enable node in debugfs in order to enable/disable aql.
This is useful for debugging purpose.

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 net/mac80211/debugfs.c     | 1 +
 net/mac80211/ieee80211_i.h | 1 +
 net/mac80211/main.c        | 1 +
 net/mac80211/tx.c          | 3 +++
 4 files changed, 6 insertions(+)

diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c
index 48f144f107d5..898ad57bebd0 100644
--- a/net/mac80211/debugfs.c
+++ b/net/mac80211/debugfs.c
@@ -581,6 +581,7 @@ void debugfs_hw_add(struct ieee80211_local *local)
 	DEBUGFS_ADD(aql_txq_limit);
 	debugfs_create_u32("aql_threshold", 0600,
 			   phyd, &local->aql_threshold);
+	debugfs_create_bool("aql_enable", 0600, phyd, &local->aql_enable);
 
 	statsd = debugfs_create_dir("statistics", phyd);
 
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 8bf9c0e974d6..8c9cce373010 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -1162,6 +1162,7 @@ struct ieee80211_local {
 	u32 aql_txq_limit_low[IEEE80211_NUM_ACS];
 	u32 aql_txq_limit_high[IEEE80211_NUM_ACS];
 	u32 aql_threshold;
+	bool aql_enable;
 	atomic_t aql_total_pending_airtime;
 
 	const struct ieee80211_ops *ops;
diff --git a/net/mac80211/main.c b/net/mac80211/main.c
index dee88ec566ad..b3bec68943c8 100644
--- a/net/mac80211/main.c
+++ b/net/mac80211/main.c
@@ -700,6 +700,7 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len,
 
 	local->airtime_flags = AIRTIME_USE_TX | AIRTIME_USE_RX;
 	local->aql_threshold = IEEE80211_AQL_THRESHOLD;
+	local->aql_enable = true;
 	atomic_set(&local->aql_total_pending_airtime, 0);
 
 	INIT_LIST_HEAD(&local->chanctx_list);
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 6422da6690f7..86503d47d86e 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -3832,6 +3832,9 @@ bool ieee80211_txq_airtime_check(struct ieee80211_hw *hw,
 	if (!wiphy_ext_feature_isset(local->hw.wiphy, NL80211_EXT_FEATURE_AQL))
 		return true;
 
+	if (!local->aql_enable)
+		return true;
+
 	if (!txq->sta)
 		return true;
 
-- 
2.29.2


             reply	other threads:[~2020-12-26  9:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-26  9:49 Lorenzo Bianconi [this message]
2021-01-04 12:15 ` [PATCH mac80211-next] mac80211: introduce aql_enable node in debugfs Toke Høiland-Jørgensen
2021-01-04 13:20   ` Lorenzo Bianconi
2021-01-04 13:47     ` Toke Høiland-Jørgensen
2021-01-04 13:54       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ad278def3875fc2c60b4898daa3f0d53288c168.1608975795.git.lorenzo@kernel.org \
    --to=lorenzo@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=kyan@google.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox