From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
kyan@google.com, Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH mac80211-next] mac80211: introduce aql_enable node in debugfs
Date: Mon, 04 Jan 2021 14:47:26 +0100 [thread overview]
Message-ID: <87pn2k4xw1.fsf@toke.dk> (raw)
In-Reply-To: <CAJ0CqmVq2+poxg_V6pMCh2CFuqt3dwUW3x6eF=J0ek_uX5k6yQ@mail.gmail.com>
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:
>>
>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>>
>> > Introduce aql_enable node in debugfs in order to enable/disable aql.
>> > This is useful for debugging purpose.
>>
>> Don't mind having a switch, although I wonder if it would be better to
>> overload the existing debugfs file (e.g., a threshold of 0 could disable
>> everything?) so as not to clutter up debugfs too much?
>>
>> -Toke
>>
>
> You mean to consider 0 as a special value to disable aql, right? I
> would prefer to have a dedicated switch for it since I guess it is
> clearer for users (but I can live with it :) )
Yeah, maybe a bit clearer but at the cost of clutter. I dunno, not a
strong preference either way; I guess Johannes can make the call :)
-Toke
next prev parent reply other threads:[~2021-01-04 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 9:49 [PATCH mac80211-next] mac80211: introduce aql_enable node in debugfs Lorenzo Bianconi
2021-01-04 12:15 ` Toke Høiland-Jørgensen
2021-01-04 13:20 ` Lorenzo Bianconi
2021-01-04 13:47 ` Toke Høiland-Jørgensen [this message]
2021-01-04 13:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn2k4xw1.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox