From: Ping-Ke Shih <pkshih@realtek.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
"Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>,
"kvalo@kernel.org" <kvalo@kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtl8xxxu: don't call dev_kfree_skb() under spin_lock_irqsave()
Date: Thu, 8 Dec 2022 00:38:04 +0000 [thread overview]
Message-ID: <0cfea9eaf08446d5a7dfcb85da34dcf2@realtek.com> (raw)
In-Reply-To: <20221207143738.67721-1-yangyingliang@huawei.com>
> -----Original Message-----
> From: Yang Yingliang <yangyingliang@huawei.com>
> Sent: Wednesday, December 7, 2022 10:38 PM
> To: Jes.Sorensen@gmail.com; kvalo@kernel.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [PATCH] wifi: rtl8xxxu: don't call dev_kfree_skb() under spin_lock_irqsave()
>
> It is not allowed to call consume_skb() from hardware interrupt context
^^^^^^^^^^^^^ kfree_skb()?
because this patch is to replace dev_kfree_skb().
> or with interrupts being disabled. So replace dev_kfree_skb() with
> dev_consume_skb_irq() under spin_lock_irqsave(). Compile tested only.
>
> Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index ac641a56efb0..d0600af5bef4 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -5274,7 +5274,7 @@ static void rtl8xxxu_queue_rx_urb(struct rtl8xxxu_priv *priv,
> pending = priv->rx_urb_pending_count;
> } else {
> skb = (struct sk_buff *)rx_urb->urb.context;
> - dev_kfree_skb(skb);
> + dev_consume_skb_irq(skb);
Why not dev_kfree_skb_irq() instead? any reason?
> usb_free_urb(&rx_urb->urb);
> }
>
> --
> 2.25.1
>
>
> ------Please consider the environment before printing this e-mail.
next prev parent reply other threads:[~2022-12-08 0:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 14:37 [PATCH] wifi: rtl8xxxu: don't call dev_kfree_skb() under spin_lock_irqsave() Yang Yingliang
2022-12-08 0:38 ` Ping-Ke Shih [this message]
2022-12-08 1:25 ` Yang Yingliang
2022-12-08 1:41 ` Ping-Ke Shih
2022-12-08 1:58 ` Yang Yingliang
2022-12-08 13:19 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cfea9eaf08446d5a7dfcb85da34dcf2@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox