* Re: [git patches] net driver updates [not found] <6.1.1.1.2.20070221124144.04783fb8@192.168.6.12> @ 2007-02-21 13:27 ` John W. Linville 2007-02-22 15:48 ` Dan Williams 0 siblings, 1 reply; 2+ messages in thread From: John W. Linville @ 2007-02-21 13:27 UTC (permalink / raw) To: Roger While; +Cc: netdev, jeff, dcbw, linux-wireless On Wed, Feb 21, 2007 at 12:46:46PM +0100, Roger While wrote: > > > > >Dan Williams (1): > > prism54: correct assignment of DOT1XENABLE in WE-19 codepaths > > Where did this spring from ? > I see no posting of this patch let alone > an ACK. > The patch is also doing rather more than the description - > It is inserting extra breaks into a switch statement with > no comment as to why. Dan posted it to linux-wireless@vger.kernel.org on 13 Feb 2007. The description in the body is quoted below: Correct assignment of DOT1XENABLE in WE-19 codepaths. RX_UNENCRYPTED_EAPOL = 1 really means setting DOT1XENABLE _off_, and vice versa. The original WE-19 patch erroneously reversed that. This patch fixes association with unencrypted and WEP networks when using wpa_supplicant. It also adds two missing break statements that, left out, could result in incorrect card configuration. Please commit to both development and stable branches. Hth... John -- John W. Linville linville@tuxdriver.com ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [git patches] net driver updates 2007-02-21 13:27 ` [git patches] net driver updates John W. Linville @ 2007-02-22 15:48 ` Dan Williams 0 siblings, 0 replies; 2+ messages in thread From: Dan Williams @ 2007-02-22 15:48 UTC (permalink / raw) To: jeff; +Cc: Roger While, netdev, linux-wireless On Wed, 2007-02-21 at 08:27 -0500, John W. Linville wrote: > On Wed, Feb 21, 2007 at 12:46:46PM +0100, Roger While wrote: > > > > > > > >Dan Williams (1): > > > prism54: correct assignment of DOT1XENABLE in WE-19 codepaths > > > > Where did this spring from ? > > I see no posting of this patch let alone > > an ACK. > > The patch is also doing rather more than the description - > > It is inserting extra breaks into a switch statement with > > no comment as to why. > > Dan posted it to linux-wireless@vger.kernel.org on 13 Feb 2007. > The description in the body is quoted below: It was also posted to stable@kernel.org and accepted for 2.6.19 and 2.6.20. Dan > Correct assignment of DOT1XENABLE in WE-19 codepaths. > RX_UNENCRYPTED_EAPOL = 1 really means setting DOT1XENABLE _off_, and > vice versa. The original WE-19 patch erroneously reversed that. This > patch fixes association with unencrypted and WEP networks when using > wpa_supplicant. > > It also adds two missing break statements that, left out, could result > in incorrect card configuration. > > Please commit to both development and stable branches. > > Hth... > > John ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-22 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <6.1.1.1.2.20070221124144.04783fb8@192.168.6.12>
2007-02-21 13:27 ` [git patches] net driver updates John W. Linville
2007-02-22 15:48 ` Dan Williams
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox