From: Johannes Berg <johannes@sipsolutions.net>
To: James Ketrenos <jketreno@linux.intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] create net/wireless/Kconfig and make nl80211 optional
Date: Fri, 23 Feb 2007 21:11:12 +0100 [thread overview]
Message-ID: <1172261472.3870.50.camel@johannes.berg> (raw)
In-Reply-To: <45DF176E.9090509@linux.intel.com>
On Fri, 2007-02-23 at 08:33 -0800, James Ketrenos wrote:
> Johannes Berg wrote:
> > On Thu, 2007-02-22 at 11:42 -0800, James Ketrenos wrote:
> >> Move the wireless Kconfig options into their own wireless/Kconfig and
> >> add a CONFIG_NL80211 configuration option to allow nl80211 support to be
> >> optionally included (default =y)
> >
> > Ack, but we'll need to modify core.h to stub out nl80211_init() and
> > nl80211_exit() in case nl80211 isn't compiled in. The reason this worked
> > for you is that I forgot to hook up nl80211 completely ;)
> >
> > Do you want me to take care of that?`
>
> Something like this?
Yup. I'd prefer this instead, and then rolled into your original patch
so it applies after my hookup patch.
johannes
--- wireless-dev.orig/net/wireless/nl80211.h 2007-02-23 21:08:45.353476868 +0100
+++ wireless-dev/net/wireless/nl80211.h 2007-02-23 21:09:58.543476868 +0100
@@ -1,7 +1,17 @@
#ifndef __NET_WIRELESS_NL80211_H
#define __NET_WIRELESS_NL80211_H
+#ifdef CONFIG_CFG80211_NL80211
extern int nl80211_init(void);
extern void nl80211_exit(void);
+#else
+static inline int nl80211_init(void)
+{
+ return 0;
+}
+static inline void nl80211_exit(void)
+{
+}
+#endif /* CONFIG_CFG80211_NL80211 */
#endif /* __NET_WIRELESS_NL80211_H */
next prev parent reply other threads:[~2007-02-23 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 19:42 [PATCH] create net/wireless/Kconfig and make nl80211 optional James Ketrenos
2007-02-23 11:25 ` Johannes Berg
2007-02-23 16:33 ` James Ketrenos
2007-02-23 20:11 ` Johannes Berg [this message]
2007-02-23 20:23 ` James Ketrenos
2007-02-23 20:35 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172261472.3870.50.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=jketreno@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox