Linux wireless drivers development
 help / color / mirror / Atom feed
From: James Ketrenos <jketreno@linux.intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] create net/wireless/Kconfig and make nl80211 optional
Date: Fri, 23 Feb 2007 08:33:50 -0800	[thread overview]
Message-ID: <45DF176E.9090509@linux.intel.com> (raw)
In-Reply-To: <1172229914.3870.13.camel@johannes.berg>

Johannes Berg wrote:
> On Thu, 2007-02-22 at 11:42 -0800, James Ketrenos wrote:
>> Move the wireless Kconfig options into their own wireless/Kconfig and
>> add a CONFIG_NL80211 configuration option to allow nl80211 support to be
>> optionally included (default =y)
> 
> Ack, but we'll need to modify core.h to stub out nl80211_init() and
> nl80211_exit() in case nl80211 isn't compiled in. The reason this worked
> for you is that I forgot to hook up nl80211 completely ;)
> 
> Do you want me to take care of that?`

Something like this?

James
--------------

[PATCH] Make nl80211_init and nl80211_exit depend on NL80211 config

This applies after Johannes patch 'hook up nl80211 again' and wraps
nl80211_init and nl80211_exit usage in CONFIG_CFG80211_NL80211.

Signed-off-by: James Ketrenos <jketreno@linux.intel.com>
---
  net/wireless/core.c |    6 ++++++
  1 file changed, 6 insertions(+)
---
diff --git a/net/wireless/core.c b/net/wireless/core.c
index abf0f78..8c1e914 100644
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -249,16 +249,20 @@ static int cfg80211_init(void)
         if (err)
                 goto out_exit_sysfs;

+#ifdef CONFIG_CFG80211_NL80211
         err = nl80211_init();
         if (err)
                 goto out_nl80211;
+#endif

         ieee80211_debugfs_dir = debugfs_create_dir("ieee80211", NULL);

         return 0;

+#ifdef CONFIG_CFG80211_NL80211
   out_nl80211:
         cfg80211_wext_exit();
+#endif
   out_exit_sysfs:
         wiphy_sysfs_exit();

@@ -269,7 +273,9 @@ module_init(cfg80211_init);
  static void cfg80211_exit(void)
  {
         debugfs_remove(ieee80211_debugfs_dir);
+#ifdef CONFIG_CFG80211_NL80211
         nl80211_exit();
+#endif
         cfg80211_wext_exit();
         wiphy_sysfs_exit();
  }





  reply	other threads:[~2007-02-23 16:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-22 19:42 [PATCH] create net/wireless/Kconfig and make nl80211 optional James Ketrenos
2007-02-23 11:25 ` Johannes Berg
2007-02-23 16:33   ` James Ketrenos [this message]
2007-02-23 20:11     ` Johannes Berg
2007-02-23 20:23       ` James Ketrenos
2007-02-23 20:35         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DF176E.9090509@linux.intel.com \
    --to=jketreno@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox