Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] mac80211: make 802.1X setting consistent with low-level driver
@ 2007-03-27 15:59 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2007-03-27 15:59 UTC (permalink / raw)
  To: Jiri Benc; +Cc: linux-wireless

If the low-level driver fails to reconfigure 802.1X we currently still
set the variable. Don't do that since it brings things out of sync.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

---
 net/mac80211/ieee80211_ioctl.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

--- wireless-dev.orig/net/mac80211/ieee80211_ioctl.c	2007-03-27 16:33:44.363155480 +0200
+++ wireless-dev/net/mac80211/ieee80211_ioctl.c	2007-03-27 16:33:44.943155480 +0200
@@ -2478,11 +2478,14 @@ static int ieee80211_ioctl_prism2_param(
 		break;
 
 	case PRISM2_PARAM_IEEE_802_1X:
-		sdata->ieee802_1x = value;
-		if (local->ops->set_ieee8021x &&
-		    local->ops->set_ieee8021x(local_to_hw(local), value))
+		if (local->ops->set_ieee8021x)
+			ret = local->ops->set_ieee8021x(local_to_hw(local),
+							value);
+		if (ret)
 			printk(KERN_DEBUG "%s: failed to set IEEE 802.1X (%d) "
 			       "for low-level driver\n", dev->name, value);
+		else
+			sdata->ieee802_1x = value;
 		break;
 
 	case PRISM2_PARAM_ANTSEL_TX:



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-03-28  9:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-27 15:59 [PATCH] mac80211: make 802.1X setting consistent with low-level driver Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox