libertas warnings & bugs

libertas warnings & bugs

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

Hi Dan,

As promised a few more warnings from libertas from my ppc64 build.

drivers/net/wireless/libertas/cmd.c: In function ‘wlan_cmd_802_11_set_wep’:
drivers/net/wireless/libertas/cmd.c:189: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/libertas/cmd.c:195: warning: large integer implicitly truncated to unsigned type

The code is:
wep->keytype[i] = cpu_to_le16(cmd_type_wep_40_bit);

and it's fairly obvious why it warns: keytype[i] is a u8 so always ends
up 0...

drivers/net/wireless/libertas/debugfs.c: In function ‘libertas_getscantable’:
drivers/net/wireless/libertas/debugfs.c:85: warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument 4 has type ‘u64’
drivers/net/wireless/libertas/debugfs.c:85: warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument 4 has type ‘u64’

probably just needs a cast to unsigned long long.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: libertas warnings & bugs

[Dan Williams]

On Wed, 2007-07-18 at 16:00 +0200, Johannes Berg wrote:
> Hi Dan,
>=20
> As promised a few more warnings from libertas from my ppc64 build.
>=20
> drivers/net/wireless/libertas/cmd.c: In function =E2=80=98wlan_cmd_80=
2_11_set_wep=E2=80=99:
> drivers/net/wireless/libertas/cmd.c:189: warning: large integer impli=
citly truncated to unsigned type
> drivers/net/wireless/libertas/cmd.c:195: warning: large integer impli=
citly truncated to unsigned type
>=20
> The code is:
> wep->keytype[i] =3D cpu_to_le16(cmd_type_wep_40_bit);
>=20
> and it's fairly obvious why it warns: keytype[i] is a u8 so always en=
ds
> up 0...
>=20
> drivers/net/wireless/libertas/debugfs.c: In function =E2=80=98liberta=
s_getscantable=E2=80=99:
> drivers/net/wireless/libertas/debugfs.c:85: warning: format =E2=80=98=
%08llx=E2=80=99 expects type =E2=80=98long long unsigned int=E2=80=99, =
but argument 4 has type =E2=80=98u64=E2=80=99
> drivers/net/wireless/libertas/debugfs.c:85: warning: format =E2=80=98=
%08llx=E2=80=99 expects type =E2=80=98long long unsigned int=E2=80=99, =
but argument 4 has type =E2=80=98u64=E2=80=99
>=20
> probably just needs a cast to unsigned long long.

Thanks, doing patch review and such today, I'll try to roll these in.

Dan


-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: libertas warnings & bugs

[Dan Williams]

On Wed, 2007-07-18 at 16:00 +0200, Johannes Berg wrote:
> Hi Dan,
>=20
> As promised a few more warnings from libertas from my ppc64 build.
>=20
> drivers/net/wireless/libertas/cmd.c: In function =E2=80=98wlan_cmd_80=
2_11_set_wep=E2=80=99:
> drivers/net/wireless/libertas/cmd.c:189: warning: large integer impli=
citly truncated to unsigned type
> drivers/net/wireless/libertas/cmd.c:195: warning: large integer impli=
citly truncated to unsigned type

=46ixed this one.

> The code is:
> wep->keytype[i] =3D cpu_to_le16(cmd_type_wep_40_bit);
>=20
> and it's fairly obvious why it warns: keytype[i] is a u8 so always en=
ds
> up 0...
>=20
> drivers/net/wireless/libertas/debugfs.c: In function =E2=80=98liberta=
s_getscantable=E2=80=99:
> drivers/net/wireless/libertas/debugfs.c:85: warning: format =E2=80=98=
%08llx=E2=80=99 expects type =E2=80=98long long unsigned int=E2=80=99, =
but argument 4 has type =E2=80=98u64=E2=80=99
> drivers/net/wireless/libertas/debugfs.c:85: warning: format =E2=80=98=
%08llx=E2=80=99 expects type =E2=80=98long long unsigned int=E2=80=99, =
but argument 4 has type =E2=80=98u64=E2=80=99
>=20
> probably just needs a cast to unsigned long long.

You probably want the 'libertas' branch, where this one doesn't
appear...  master is plain linus kernels.  The layout was suggested by
linville but maybe it's confusing?

Dan


-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: libertas warnings & bugs

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

On Thu, 2007-07-19 at 16:00 -0400, Dan Williams wrote:

> You probably want the 'libertas' branch, where this one doesn't
> appear...  master is plain linus kernels.  The layout was suggested by
> linville but maybe it's confusing?

Actually, I was using plain Linus kernel :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]