[PATCH] mac80211: don't send packets to interfaces that are down

[PATCH] mac80211: don't send packets to interfaces that are down

[Johannes Berg]

David Woodhouse noticed that under some circumstances the number of slab
allocations kept growing. After looking a bit, this seemed to happen
when you had a management mode interface that was *down*.

The reason for this is that when the device is down, all management
frames get queued to the in-kernel MLME (via ieee80211_sta_rx_mgmt) but
then the sta work is invoked but doesn't run when the netif is down.
When you then bring the interface up, all such frames are freed, but if
you change the mode all of them are lost because the skb queue is
reinitialised as soon as you go back to managed mode. The skb queue is
correctly cleared when the interface is brought down, but the code
doesn't account for the fact that it may be filled while it is not up.

This patch should fix the issue by simply ignoring all interfaces that
are down when going through the RX handlers.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

---
Is there a possibility of a race condition here? If the interface is
brought down right after this check the SKB could be copied to that
interface after the skb queue has been flushed.

 net/mac80211/rx.c |    3 +++
 1 file changed, 3 insertions(+)

--- wireless-dev.orig/net/mac80211/rx.c	2007-08-14 16:18:10.924225996 +0200
+++ wireless-dev/net/mac80211/rx.c	2007-08-14 16:18:27.014225996 +0200
@@ -1511,6 +1511,9 @@ void __ieee80211_rx(struct ieee80211_hw 
 	list_for_each_entry(sdata, &local->sub_if_list, list) {
 		rx.u.rx.ra_match = 1;
 
+		if (!netif_running(sdata->dev))
+			continue;
+
 		prepres = prepare_for_handlers(sdata, bssid, &rx, hdr);
 		/* prepare_for_handlers can change sta */
 		sta = rx.sta;

Re: [PATCH] mac80211: don't send packets to interfaces that are down

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

On Tue, 2007-08-14 at 16:28 +0200, Johannes Berg wrote:

> Is there a possibility of a race condition here? If the interface is
> brought down right after this check the SKB could be copied to that
> interface after the skb queue has been flushed.

Oh once we sort that out this should go to all applicable kernels ASAP,
including -stable I think (this is in stable right? :) )

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]