From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <Kalle.Valo@nokia.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH] mac80211: don't send invalid QoS frames
Date: Fri, 31 Aug 2007 12:12:01 +0200 [thread overview]
Message-ID: <1188555121.7585.21.camel@johannes.berg> (raw)
In-Reply-To: <87wsvcksbl.fsf@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Fri, 2007-08-31 at 11:43 +0300, Kalle Valo wrote:
> Now b43 won't send any unicast frames to N800 according to a wireless
> sniffer (and packet loss is 100%, obviously). Broadcast frames are
> sent and N800 replies to ARP requests just fine.
>
> I was a bit surprised by the result, so I double checked my tests.
> After reverting this patch unicast frames were sent again, just that
> QoS frames were broken as expected. So this patch definetely broke
> unicast QoS send.
Huh, ok, I'll take another look.
> Tested with wireless-dev#anything commit 60faa0c2 and N800 had PSM
> disabled. I didn't have time to test with QoS disabled, sorry. But I
> can test that later, if you want.
I don't think it matters much. You should rather look into why the N800
is accepting those bogus frames :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-08-31 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 14:22 [PATCH] mac80211: don't send invalid QoS frames Johannes Berg
2007-08-31 8:43 ` Kalle Valo
2007-08-31 10:12 ` Johannes Berg [this message]
2007-08-31 11:25 ` Johannes Berg
2007-08-31 11:37 ` [PATCH v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188555121.7585.21.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Kalle.Valo@nokia.com \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox