From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless <linux-wireless@vger.kernel.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>,
Kalle Valo <Kalle.Valo@nokia.com>
Subject: Re: [PATCH] mac80211: don't send invalid QoS frames
Date: Fri, 31 Aug 2007 13:25:28 +0200 [thread overview]
Message-ID: <1188559528.7585.35.camel@johannes.berg> (raw)
In-Reply-To: <1188483732.3978.13.camel@johannes.berg>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
Oh, I see a bug.
On Thu, 2007-08-30 at 16:22 +0200, Johannes Berg wrote:
> + if (fc & IEEE80211_STYPE_QOS_DATA) {
> + __le16 *qos_control;
> +
> + memcpy(skb_push(skb, hdrlen - 2), &hdr, hdrlen - 2);
> + qos_control = (__le16*) skb_push(skb, 2);
These last two statements should be the other way around, of course.
We're pushing data into the head of the skb here, so we need to push the
QoS control field first and then the header. The way I wrote it there
the zeroed field ends up being the frame control field, indicating that
it's an association request frame. You should be seeing those as mangled
frames in wireshark though.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-08-31 21:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 14:22 [PATCH] mac80211: don't send invalid QoS frames Johannes Berg
2007-08-31 8:43 ` Kalle Valo
2007-08-31 10:12 ` Johannes Berg
2007-08-31 11:25 ` Johannes Berg [this message]
2007-08-31 11:37 ` [PATCH v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188559528.7585.35.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Kalle.Valo@nokia.com \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox