From: Johannes Berg <johannes@sipsolutions.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Satyam Sharma <satyam@infradead.org>,
Florian Lohoff <flo@rfc822.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
linux-wireless@vger.kernel.org,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
ipw3945-devel@lists.sourceforge.net, yi.zhu@intel.com,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170
Date: Thu, 06 Sep 2007 14:09:35 +0200 [thread overview]
Message-ID: <1189080575.28781.65.camel@johannes.berg> (raw)
In-Reply-To: <20070906082301.GB21929@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Thu, 2007-09-06 at 16:23 +0800, Herbert Xu wrote:
> On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote:
> >
> > > > [ 382.529041] [<c02c8abc>] dev_close+0x24/0x67
> > > > [ 382.529052] [<e01f402b>] ieee80211_master_stop+0x4a/0x6d [mac80211]
>
> This is where the bug is. You cannot call dev_close from an
> atomic context as i33380211_master_stop does it within spin
> locks.
Hah, I suspected as much but didn't have a chance to look yet. I had
plans to replace that sub_if_list with an RCU list and not require the
lock there, but that's far off. Any ideas how to fix this? We can't
reject the master stop so we have to walk the list, I guess we'll have
to audit the other list manipulation places, I think they're all under
RTNL.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-09-06 12:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070902184439.GA14306@paradigm.rfc822.org>
2007-09-02 23:59 ` BUG: scheduling while atomic: ifconfig/0x00000002/4170 Michal Piotrowski
2007-09-06 5:02 ` Satyam Sharma
2007-09-06 8:20 ` Herbert Xu
2007-09-06 8:23 ` Herbert Xu
2007-09-06 8:41 ` Satyam Sharma
2007-09-06 8:38 ` Florian Lohoff
2007-09-06 12:09 ` Johannes Berg [this message]
2007-09-06 12:36 ` Herbert Xu
2007-09-06 12:44 ` Johannes Berg
2007-09-06 13:36 ` Johannes Berg
2007-09-06 15:46 ` Paul E. McKenney
2007-09-07 13:27 ` Johannes Berg
2007-09-07 14:25 ` Paul E. McKenney
2007-09-07 14:30 ` Johannes Berg
2007-09-07 14:35 ` Johannes Berg
2007-09-07 14:38 ` [RFC] mac80211: fix virtual interface locking Johannes Berg
2007-09-07 16:01 ` BUG: scheduling while atomic: ifconfig/0x00000002/4170 Michael Buesch
2007-09-07 19:17 ` Johannes Berg
2007-09-06 12:52 ` Satyam Sharma
2007-09-06 12:46 ` Johannes Berg
2007-09-06 15:19 ` Johannes Berg
2007-09-12 12:34 ` David Miller
2007-09-13 7:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189080575.28781.65.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=flo@rfc822.org \
--cc=herbert@gondor.apana.org.au \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=satyam@infradead.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox