public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: paulmck@linux.vnet.ibm.com
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	satyam@infradead.org, flo@rfc822.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, michal.k.k.piotrowski@gmail.com,
	ipw3945-devel@lists.sourceforge.net, yi.zhu@intel.com,
	flamingice@sourmilk.net
Subject: Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170
Date: Fri, 07 Sep 2007 16:35:59 +0200	[thread overview]
Message-ID: <1189175759.28781.169.camel@johannes.berg> (raw)
In-Reply-To: <20070907142538.GC8864@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

On Fri, 2007-09-07 at 07:25 -0700, Paul E. McKenney wrote:

> > > > @@ -226,22 +225,22 @@ void ieee80211_if_reinit(struct net_devi
> > > >  		/* Remove all virtual interfaces that use this BSS
> > > >  		 * as their sdata->bss */
> > > >  		struct ieee80211_sub_if_data *tsdata, *n;
> > > > -		LIST_HEAD(tmp_list);
> > > > 
> > > > -		write_lock_bh(&local->sub_if_lock);
> > > 
> > > This code is also protected by RTNL?
> > 
> > Yes.
> 
> Comment?  (Or is it in the function header?)

Oh, forgot to say: yes, there is a comment further up and even an
ASSERT_RTNL()

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

  parent reply	other threads:[~2007-09-07 14:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070902184439.GA14306@paradigm.rfc822.org>
2007-09-02 23:59 ` BUG: scheduling while atomic: ifconfig/0x00000002/4170 Michal Piotrowski
2007-09-06  5:02   ` Satyam Sharma
2007-09-06  8:20     ` Herbert Xu
2007-09-06  8:23     ` Herbert Xu
2007-09-06  8:41       ` Satyam Sharma
2007-09-06  8:38         ` Florian Lohoff
2007-09-06 12:09       ` Johannes Berg
2007-09-06 12:36         ` Herbert Xu
2007-09-06 12:44           ` Johannes Berg
2007-09-06 13:36           ` Johannes Berg
2007-09-06 15:46             ` Paul E. McKenney
2007-09-07 13:27               ` Johannes Berg
2007-09-07 14:25                 ` Paul E. McKenney
2007-09-07 14:30                   ` Johannes Berg
2007-09-07 14:35                   ` Johannes Berg [this message]
2007-09-07 14:38                   ` [RFC] mac80211: fix virtual interface locking Johannes Berg
2007-09-07 16:01                 ` BUG: scheduling while atomic: ifconfig/0x00000002/4170 Michael Buesch
2007-09-07 19:17                   ` Johannes Berg
2007-09-06 12:52         ` Satyam Sharma
2007-09-06 12:46           ` Johannes Berg
2007-09-06 15:19       ` Johannes Berg
2007-09-12 12:34         ` David Miller
2007-09-13  7:16           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1189175759.28781.169.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=flamingice@sourmilk.net \
    --cc=flo@rfc822.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=satyam@infradead.org \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox