* iwlwifi sparse warnings with __CHECK_ENDIAN__
@ 2007-09-06 17:33 Johannes Berg
2007-09-08 7:37 ` Tomas Winkler
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2007-09-06 17:33 UTC (permalink / raw)
To: linux-wireless; +Cc: Tomas Winkler, Zhu Yi
[-- Attachment #1: Type: text/plain, Size: 5208 bytes --]
drivers/net/wireless/iwl-3945.c:949:3: warning: incorrect type in argument 3 (different base types)
drivers/net/wireless/iwl-3945.c:949:3: expected int
drivers/net/wireless/iwl-3945.c:949:3: got restricted unsigned short [usertype] board_revision
drivers/net/wireless/iwl-3945.c:954:3: warning: incorrect type in argument 3 (different base types)
drivers/net/wireless/iwl-3945.c:954:3: expected int
drivers/net/wireless/iwl-3945.c:954:3: got restricted unsigned short [usertype] board_revision
drivers/net/wireless/iwl-3945.c:1650:15: warning: cast from restricted type
drivers/net/wireless/iwl-base.c:1703:17: warning: cast to restricted type
drivers/net/wireless/iwl-base.c:2168:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2168:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2168:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2169:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2169:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2169:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2170:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2170:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2170:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2171:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2171:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2171:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2172:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2172:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2172:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2178:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2178:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2178:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2180:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2180:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2180:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2182:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2182:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2182:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2184:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2184:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2184:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2185:4: warning: incorrect type in initializer (different base types)
drivers/net/wireless/iwl-base.c:2185:4: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2185:4: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2220:16: warning: incorrect type in assignment (different base types)
drivers/net/wireless/iwl-base.c:2220:16: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2220:16: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2222:16: warning: incorrect type in assignment (different base types)
drivers/net/wireless/iwl-base.c:2222:16: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2222:16: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2267:14: warning: incorrect type in assignment (different base types)
drivers/net/wireless/iwl-base.c:2267:14: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2267:14: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2271:14: warning: incorrect type in assignment (different base types)
drivers/net/wireless/iwl-base.c:2271:14: expected restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-base.c:2271:14: got restricted unsigned int [usertype] [force] <noident>
drivers/net/wireless/iwl-base.c:2279:2: warning: incorrect type in argument 3 (different base types)
drivers/net/wireless/iwl-base.c:2279:2: expected int
drivers/net/wireless/iwl-base.c:2279:2: got restricted unsigned short [usertype] flags
drivers/net/wireless/iwl-4965.c:490:18: warning: restricted degrades to integer
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: iwlwifi sparse warnings with __CHECK_ENDIAN__
2007-09-06 17:33 iwlwifi sparse warnings with __CHECK_ENDIAN__ Johannes Berg
@ 2007-09-08 7:37 ` Tomas Winkler
2007-09-08 7:41 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Tomas Winkler @ 2007-09-08 7:37 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Zhu Yi
I'm not sure that you are running latest iwlwifi.
There is only one warning with __CHECK_ENDIAN__ which I don't know how
to solve cleanly.
Yet the code is correct and it is even running on a PPC machine.
Tomas
On 9/6/07, Johannes Berg <johannes@sipsolutions.net> wrote:
> drivers/net/wireless/iwl-3945.c:949:3: warning: incorrect type in argument 3 (different base types)
> drivers/net/wireless/iwl-3945.c:949:3: expected int
> drivers/net/wireless/iwl-3945.c:949:3: got restricted unsigned short [usertype] board_revision
> drivers/net/wireless/iwl-3945.c:954:3: warning: incorrect type in argument 3 (different base types)
> drivers/net/wireless/iwl-3945.c:954:3: expected int
> drivers/net/wireless/iwl-3945.c:954:3: got restricted unsigned short [usertype] board_revision
> drivers/net/wireless/iwl-3945.c:1650:15: warning: cast from restricted type
> drivers/net/wireless/iwl-base.c:1703:17: warning: cast to restricted type
> drivers/net/wireless/iwl-base.c:2168:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2168:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2168:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2169:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2169:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2169:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2170:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2170:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2170:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2171:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2171:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2171:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2172:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2172:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2172:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2178:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2178:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2178:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2180:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2180:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2180:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2182:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2182:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2182:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2184:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2184:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2184:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2185:4: warning: incorrect type in initializer (different base types)
> drivers/net/wireless/iwl-base.c:2185:4: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2185:4: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2220:16: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/iwl-base.c:2220:16: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2220:16: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2222:16: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/iwl-base.c:2222:16: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2222:16: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2267:14: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/iwl-base.c:2267:14: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2267:14: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2271:14: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/iwl-base.c:2271:14: expected restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-base.c:2271:14: got restricted unsigned int [usertype] [force] <noident>
> drivers/net/wireless/iwl-base.c:2279:2: warning: incorrect type in argument 3 (different base types)
> drivers/net/wireless/iwl-base.c:2279:2: expected int
> drivers/net/wireless/iwl-base.c:2279:2: got restricted unsigned short [usertype] flags
> drivers/net/wireless/iwl-4965.c:490:18: warning: restricted degrades to integer
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: iwlwifi sparse warnings with __CHECK_ENDIAN__
2007-09-08 7:37 ` Tomas Winkler
@ 2007-09-08 7:41 ` Johannes Berg
2007-09-08 8:20 ` Tomas Winkler
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2007-09-08 7:41 UTC (permalink / raw)
To: Tomas Winkler; +Cc: linux-wireless, Zhu Yi
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]
On Sat, 2007-09-08 at 10:37 +0300, Tomas Winkler wrote:
> I'm not sure that you are running latest iwlwifi.
I have the latest wireless-dev.
> There is only one warning with __CHECK_ENDIAN__ which I don't know how
> to solve cleanly.
> Yet the code is correct and it is even running on a PPC machine.
Ok. Like I said to Michael, I just happened to run it to see something
else and figured I'd post it.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: iwlwifi sparse warnings with __CHECK_ENDIAN__
2007-09-08 7:41 ` Johannes Berg
@ 2007-09-08 8:20 ` Tomas Winkler
2007-09-08 9:38 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Tomas Winkler @ 2007-09-08 8:20 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Zhu Yi
On 9/8/07, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Sat, 2007-09-08 at 10:37 +0300, Tomas Winkler wrote:
> > I'm not sure that you are running latest iwlwifi.
>
> I have the latest wireless-dev.
>
The version in wireless-dev is 0.1.8 and we are 0.1.15 on stable and
1.1.0 on the development branch. Looks like Yi's patches weren't
synced for a while.
Tomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: iwlwifi sparse warnings with __CHECK_ENDIAN__
2007-09-08 8:20 ` Tomas Winkler
@ 2007-09-08 9:38 ` Johannes Berg
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2007-09-08 9:38 UTC (permalink / raw)
To: Tomas Winkler; +Cc: linux-wireless, Zhu Yi
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On Sat, 2007-09-08 at 11:20 +0300, Tomas Winkler wrote:
> The version in wireless-dev is 0.1.8 and we are 0.1.15 on stable and
> 1.1.0 on the development branch. Looks like Yi's patches weren't
> synced for a while.
Huh ok. John is at KS anyhow, but we really need a better plan how to
continue developing stuff. No wonder if I've been looking at ancient
code all along...
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-09-08 9:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-06 17:33 iwlwifi sparse warnings with __CHECK_ENDIAN__ Johannes Berg
2007-09-08 7:37 ` Tomas Winkler
2007-09-08 7:41 ` Johannes Berg
2007-09-08 8:20 ` Tomas Winkler
2007-09-08 9:38 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox