hostapd: passing sta info struct to drivers?

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi,

During porting the STA management to nl80211 it turned out that it would
be much nicer in the kernel if we would always set all the flags on a
STA that the kernel needs to get from hostapd.

To implement that, it would be good to simply pass the sta_info
structure, e.g. we currently have this code:

        if (sta->flags & WLAN_STA_WME)
                hostapd_sta_set_flags(hapd, sta->addr, WLAN_STA_WME, ~0);
        else
                hostapd_sta_set_flags(hapd, sta->addr, 0, ~WLAN_STA_WME);

and that would become

	hostapd_sta_set_flags(hapd, sta, WLAN_STA_WME);
or
	hostapd_sta_set_flags(hapd, sta->flags, WLAN_STA_WME);

where the third parameter indicates which flag may have changed and the
nl80211 driver would simply use only the flags.

Do you see any issues with that? Are there sometimes flag changes that
we do not want to commit to the kernel?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]