* [PATCH] ath5k: undo overzealous hunk of "ath5k: avoid oops when..."
@ 2007-10-23 17:43 John W. Linville
2007-10-23 19:05 ` Luis R. Rodriguez
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2007-10-23 17:43 UTC (permalink / raw)
To: linux-wireless; +Cc: Luis R. Rodriguez, John W. Linville
The first hunk of "ath5k: avoid oops when ah_capabilities.cap_mode not
set" was ill-advised. It can cause the it's loop to abort prematurely.
Signed-off-by: John W. Linville <linville.tuxdriver.com>
---
drivers/net/wireless/ath5k/base.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index c38adab..e764fd3 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -1991,9 +1991,6 @@ static int ath5k_getchannels(struct ieee80211_hw *hw)
}
hw_rates = ath5k_hw_get_rate_table(ah, mode->mode);
- if (!hw_rates)
- return -EINVAL;
-
mode->num_rates = ath5k_copy_rates(mode->rates, hw_rates,
max_r);
mode->num_channels = ath5k_copy_channels(ah, mode->channels,
--
1.5.2.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath5k: undo overzealous hunk of "ath5k: avoid oops when..."
2007-10-23 17:43 [PATCH] ath5k: undo overzealous hunk of "ath5k: avoid oops when..." John W. Linville
@ 2007-10-23 19:05 ` Luis R. Rodriguez
0 siblings, 0 replies; 2+ messages in thread
From: Luis R. Rodriguez @ 2007-10-23 19:05 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
On 10/23/07, John W. Linville <linville@tuxdriver.com> wrote:
> The first hunk of "ath5k: avoid oops when ah_capabilities.cap_mode not
> set" was ill-advised. It can cause the it's loop to abort prematurely.
>
> Signed-off-by: John W. Linville <linville.tuxdriver.com>
Acked-by: Luis R. Rodriguez <mcgrof@gmail.com>
Luis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-23 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-23 17:43 [PATCH] ath5k: undo overzealous hunk of "ath5k: avoid oops when..." John W. Linville
2007-10-23 19:05 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox