Re: [PATCH] mac80211: remove "bcn_int" and "capab" scan results info

[Johannes Berg <johannes@sipsolutions.net>]

> > If I understood correctly, the proposed change was removing 'capab'
> > information from scan results(?). If that is the case, that would break
> > wpa_supplicant network selection since there would be no information on
> > whether the network is using encryption or not (privacy flag) and
> > whether it is a BSS or an IBSS. Consequently, I obviously continue to
> > object this type of change as long as WE is used for getting scan
> > results.
> 
> Well, wpa_supplicant currently works, right? And this code is never
> triggered before the change to remove scan_flags because scan_flags
> cannot be set. Hence, I don't see how wpa_supplicant can possibly need
> this information.

In fact, wpa_supplicant isn't even using the capab= information from the
possibly present custom structure in the scan result, it uses
SIOCGIWMODE to figure out whether it's a BSS or an IBSS, and probably
IWEVGENIE to figure out encryption.

The only thing it can possibly read from the custom scan result is
wpa_ie= and rsn_ie= which are IWEVGENIE and tsf= which we never pass.

Therefore, we should merge this patch.

johannes