From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: remove "bcn_int" and "capab" scan results info
Date: Wed, 21 Nov 2007 20:31:56 -0800 [thread overview]
Message-ID: <20071122043156.GB8672@jm.kir.nu> (raw)
In-Reply-To: <1195664475.12000.54.camel@johannes.berg>
On Wed, Nov 21, 2007 at 06:01:15PM +0100, Johannes Berg wrote:
> On Wed, 2007-11-21 at 11:55 -0500, John W. Linville wrote:
> > These bits were dead code before "mac80211: Remove local->scan_flags"
> > (commit 6681dd3fd0e4d36a4547415853e83411baa7b705) and probably should
> > have been removed as part of that commit.
>
> I'm all for it. But Jouni complained although this code couldn't be
> triggered. I think Jouni's objections will be addressed with nl80211
> work though, so maybe we can remove it for now anyway?
If I understood correctly, the proposed change was removing 'capab'
information from scan results(?). If that is the case, that would break
wpa_supplicant network selection since there would be no information on
whether the network is using encryption or not (privacy flag) and
whether it is a BSS or an IBSS. Consequently, I obviously continue to
object this type of change as long as WE is used for getting scan
results.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2007-11-22 4:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 16:55 [PATCH] mac80211: remove "bcn_int" and "capab" scan results info John W. Linville
2007-11-21 17:01 ` Johannes Berg
2007-11-22 4:31 ` Jouni Malinen [this message]
2007-11-22 12:57 ` Johannes Berg
2007-11-23 10:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071122043156.GB8672@jm.kir.nu \
--to=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox