Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: don't use if_id, use if_priv
Date: Mon, 03 Dec 2007 11:44:02 +0100	[thread overview]
Message-ID: <1196678642.6060.32.camel@johannes.berg> (raw)
In-Reply-To: <200711302059.23415.flamingice@sourmilk.net>

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]


> Note that a good chunk of the if_id stuff in the api was just brain damage 
> from the ERP info changes. Anywhere we have access to a skb, we have access 
> to a netdev, and we don't need an extra if_id argument to tell us what we 
> need to know. I would love to see that get fixed first as that simplifies all 
> drivers.

True enough. But do we want to have drivers rely on that? Right now,
what parts of the patch do is use the tx_control->if_priv field for
getting back to mac80211 about e.g. CTS/RTS duration. That's not
something we should be requiring an SKB for.

> Having said that, a per-interface private area for drivers is a great idea if 
> drivers need it. They probably do.

So far I've been able to do without it in b43/multi-BSS code but I think
that more interesting things may need it so...

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2007-12-03 10:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 11:48 [RFC] mac80211: don't use if_id, use if_priv Johannes Berg
2007-11-30 16:33 ` Luis R. Rodriguez
2007-12-03 10:42   ` Johannes Berg
2007-12-01  1:59 ` Michael Wu
2007-12-03 10:44   ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196678642.6060.32.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=flamingice@sourmilk.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox