Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] mac80211: remove misleading 'res' variable
@ 2007-12-23  9:11 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2007-12-23  9:11 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

When this function returns != CONTINUE, it needs to put the
station struct it has acquired. Hence, having this unused
variable is not just superfluous but also misleading.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/tx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- everything.orig/net/mac80211/tx.c	2007-12-23 10:09:52.148939344 +0100
+++ everything/net/mac80211/tx.c	2007-12-23 10:09:57.548937012 +0100
@@ -932,7 +932,6 @@ __ieee80211_tx_prepare(struct ieee80211_
 	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
 	struct ieee80211_hdr *hdr;
 	struct ieee80211_sub_if_data *sdata;
-	ieee80211_txrx_result res = TXRX_CONTINUE;
 
 	int hdrlen;
 
@@ -997,7 +996,7 @@ __ieee80211_tx_prepare(struct ieee80211_
 	}
 	control->flags |= IEEE80211_TXCTL_FIRST_FRAGMENT;
 
-	return res;
+	return TXRX_CONTINUE;
 }
 
 /*



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-12-23  9:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-23  9:11 [PATCH] mac80211: remove misleading 'res' variable Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox