* [PATCH] libertas: fix interrupt while removing driver
@ 2008-01-25 13:15 Holger Schurig
2008-01-25 15:48 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Holger Schurig @ 2008-01-25 13:15 UTC (permalink / raw)
To: John W. Linville; +Cc: Dan Williams, libertas-dev, linux-wireless
Previously I've got an interrupt while removing the driver.
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Index: wireless-2.6/drivers/net/wireless/libertas/if_cs.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/libertas/if_cs.c 2008-01-25 13:54:08.000000000 +0100
+++ wireless-2.6/drivers/net/wireless/libertas/if_cs.c 2008-01-25 13:54:50.000000000 +0100
@@ -249,14 +249,14 @@ static irqreturn_t if_cs_interrupt(int i
lbs_deb_enter(LBS_DEB_CS);
int_cause = if_cs_read16(card, IF_CS_C_INT_CAUSE);
- if(int_cause == 0x0) {
+ if (int_cause == 0x0) {
/* Not for us */
return IRQ_NONE;
} else if (int_cause == 0xffff) {
/* Read in junk, the card has probably been removed */
card->priv->surpriseremoved = 1;
-
+ return IRQ_HANDLED;
} else {
if (int_cause & IF_CS_H_IC_TX_OVER)
lbs_host_to_card_done(card->priv);
@@ -715,8 +715,8 @@ static void if_cs_release(struct pcmcia_
lbs_deb_enter(LBS_DEB_CS);
- pcmcia_disable_device(p_dev);
free_irq(p_dev->irq.AssignedIRQ, card);
+ pcmcia_disable_device(p_dev);
if (card->iobase)
ioport_unmap(card->iobase);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libertas: fix interrupt while removing driver
2008-01-25 13:15 [PATCH] libertas: fix interrupt while removing driver Holger Schurig
@ 2008-01-25 15:48 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2008-01-25 15:48 UTC (permalink / raw)
To: Holger Schurig; +Cc: John W. Linville, libertas-dev, linux-wireless
On Fri, 2008-01-25 at 14:15 +0100, Holger Schurig wrote:
> Previously I've got an interrupt while removing the driver.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
>
> Index: wireless-2.6/drivers/net/wireless/libertas/if_cs.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/if_cs.c 2008-01-25 13:54:08.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/if_cs.c 2008-01-25 13:54:50.000000000 +0100
> @@ -249,14 +249,14 @@ static irqreturn_t if_cs_interrupt(int i
> lbs_deb_enter(LBS_DEB_CS);
>
> int_cause = if_cs_read16(card, IF_CS_C_INT_CAUSE);
> - if(int_cause == 0x0) {
> + if (int_cause == 0x0) {
> /* Not for us */
> return IRQ_NONE;
>
> } else if (int_cause == 0xffff) {
> /* Read in junk, the card has probably been removed */
> card->priv->surpriseremoved = 1;
> -
> + return IRQ_HANDLED;
> } else {
> if (int_cause & IF_CS_H_IC_TX_OVER)
> lbs_host_to_card_done(card->priv);
> @@ -715,8 +715,8 @@ static void if_cs_release(struct pcmcia_
>
> lbs_deb_enter(LBS_DEB_CS);
>
> - pcmcia_disable_device(p_dev);
> free_irq(p_dev->irq.AssignedIRQ, card);
> + pcmcia_disable_device(p_dev);
> if (card->iobase)
> ioport_unmap(card->iobase);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-25 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-25 13:15 [PATCH] libertas: fix interrupt while removing driver Holger Schurig
2008-01-25 15:48 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox