Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] mac80211: fix initialisation error path
@ 2008-01-31 18:33 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2008-01-31 18:33 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

The error handling in ieee80211_init() is broken when any of
the built-in rate control algorithms fail to initialise, fix
it and rename the error labels.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/ieee80211.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

--- everything.orig/net/mac80211/ieee80211.c	2008-01-31 19:30:42.162269153 +0100
+++ everything/net/mac80211/ieee80211.c	2008-01-31 19:31:21.572266440 +0100
@@ -1684,28 +1684,28 @@ static int __init ieee80211_init(void)
 
 	ret = rc80211_simple_init();
 	if (ret)
-		goto fail;
+		goto out;
 
 	ret = rc80211_pid_init();
 	if (ret)
-		goto fail_simple;
+		goto out_cleanup_simple;
 
 	ret = ieee80211_wme_register();
 	if (ret) {
 		printk(KERN_DEBUG "ieee80211_init: failed to "
 		       "initialize WME (err=%d)\n", ret);
-		goto fail_pid;
+		goto out_cleanup_pid;
 	}
 
 	ieee80211_debugfs_netdev_init();
 
 	return 0;
 
- fail_pid:
-	rc80211_simple_exit();
- fail_simple:
+ out_cleanup_pid:
 	rc80211_pid_exit();
- fail:
+ out_cleanup_simple:
+	rc80211_simple_exit();
+ out:
 	return ret;
 }
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-01 12:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-31 18:33 [PATCH] mac80211: fix initialisation error path Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox