From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@winlab.rutgers.edu>
Cc: linville@tuxdriver.com, ath5k-devel@lists.ath5k.org,
linux-wireless@vger.kernel.org, bruno@thinktube.com,
jirislaby@gmail.com, mickflemm@gmail.com
Subject: Re: [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band
Date: Fri, 01 Feb 2008 13:13:38 +0100 [thread overview]
Message-ID: <1201868018.4188.2.camel@johannes.berg> (raw)
In-Reply-To: <20080201012628.GE28995@ruslug.rutgers.edu> (sfid-20080201_022633_385916_137874C0)
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
Your CC lists are somehow messed up... some things are on twice.
> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index bd9c9a8..1e7eeec 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -899,6 +899,8 @@ ath5k_copy_channels(struct ath5k_hw *ah,
>
> /* Write channel info and increment counter */
> channels[count].center_freq = freq;
> + channels[count].band = (chfreq == CHANNEL_2GHZ) ?
> + IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ;
No need, cfg80211 will do that when you register the wiphy.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2008-02-01 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 1:26 [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band Luis R. Rodriguez
2008-02-01 12:13 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201868018.4188.2.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=ath5k-devel@lists.ath5k.org \
--cc=bruno@thinktube.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@winlab.rutgers.edu \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox