Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band
@ 2008-02-01  1:26 Luis R. Rodriguez
  2008-02-01 12:13 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Luis R. Rodriguez @ 2008-02-01  1:26 UTC (permalink / raw)
  To: linville; +Cc: ath5k-devel, linux-wireless, bruno, jirislaby, johannes,
	mickflemm

ath5k_copy_channels() wasn't setting the channel's band so all
driver channels had a 2GHz band set. Lets set this.

Signed-off-by: Luis R. Rodriguez <mcgrof@winlab.rutgers.edu>

drivers/net/wireless/ath5k/base.c:	Changes-licensed-under: 3-Clause-BSD
---
 drivers/net/wireless/ath5k/base.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index bd9c9a8..1e7eeec 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -899,6 +899,8 @@ ath5k_copy_channels(struct ath5k_hw *ah,
 
 		/* Write channel info and increment counter */
 		channels[count].center_freq = freq;
+		channels[count].band = (chfreq == CHANNEL_2GHZ) ?
+			IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ;
 
 		if ((mode == AR5K_MODE_11A) ||
 			(mode == AR5K_MODE_11G)) {
-- 
1.5.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band
  2008-02-01  1:26 [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band Luis R. Rodriguez
@ 2008-02-01 12:13 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2008-02-01 12:13 UTC (permalink / raw)
  To: Luis R. Rodriguez
  Cc: linville, ath5k-devel, linux-wireless, bruno, jirislaby,
	mickflemm

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

Your CC lists are somehow messed up... some things are on twice.


> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index bd9c9a8..1e7eeec 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -899,6 +899,8 @@ ath5k_copy_channels(struct ath5k_hw *ah,
>  
>  		/* Write channel info and increment counter */
>  		channels[count].center_freq = freq;
> +		channels[count].band = (chfreq == CHANNEL_2GHZ) ?
> +			IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ;

No need, cfg80211 will do that when you register the wiphy.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-01 12:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-01  1:26 [PATCH 2/2] ath5k: ath5k_copy_channels() was not setting the channel band Luis R. Rodriguez
2008-02-01 12:13 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox