* [PATCH] mac80211: fix debugfs_sta print_mac() warning
[not found] ` <1203588993.20345.27.camel@brick>
@ 2008-02-21 10:22 ` Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2008-02-21 10:22 UTC (permalink / raw)
To: John Linville; +Cc: David Miller, joe, netdev, Harvey Harrison, linux-wireless
When print_mac() was marked as __pure to avoid emitting a function
call in pr_debug() scenarios, a warning in this code surfaced since
it relies on the fact that the buffer is modified and doesn't use
the return value. This patch makes it use the return value instead.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Reported-by: Harvey Harrison <harvey.harrison@gmail.com>
---
net/mac80211/debugfs_sta.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- everything.orig/net/mac80211/debugfs_sta.c 2008-02-21 11:17:48.000000000 +0100
+++ everything/net/mac80211/debugfs_sta.c 2008-02-21 11:17:59.000000000 +0100
@@ -297,12 +297,13 @@ STA_OPS_WR(agg_status);
void ieee80211_sta_debugfs_add(struct sta_info *sta)
{
struct dentry *stations_dir = sta->local->debugfs.stations;
- DECLARE_MAC_BUF(mac);
+ DECLARE_MAC_BUF(mbuf);
+ u8 *mac;
if (!stations_dir)
return;
- print_mac(mac, sta->addr);
+ mac = print_mac(mbuf, sta->addr);
sta->debugfs.dir = debugfs_create_dir(mac, stations_dir);
if (!sta->debugfs.dir)
^ permalink raw reply [flat|nested] only message in thread