From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: Luis Carlos Cobo <luisca@cozybit.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] mac80211: add missing "break" statement in mesh code
Date: Mon, 25 Feb 2008 10:11:50 +0100 [thread overview]
Message-ID: <1203930711.13162.46.camel@johannes.berg> (raw)
This inserts a missing break statement which, if hit, would cause
the code to fall-through and unlock a spinlock twice. Noticed via
sparse's "lock count wrong in basic block" warning and careful
code inspection.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Carlos Cobo <luisca@cozybit.com>
---
net/mac80211/mesh_plink.c | 1 +
1 file changed, 1 insertion(+)
--- everything.orig/net/mac80211/mesh_plink.c 2008-02-24 12:22:02.000000000 +0100
+++ everything/net/mac80211/mesh_plink.c 2008-02-24 12:22:18.000000000 +0100
@@ -691,6 +691,7 @@ void mesh_rx_plink_frame(struct net_devi
spin_unlock_bh(&sta->plink_lock);
mesh_plink_frame_tx(dev, PLINK_CLOSE, sta->addr, llid,
plid, reason);
+ break;
case OPN_ACPT:
if (del_timer(&sta->plink_timer))
sta_info_put(sta);
reply other threads:[~2008-02-25 9:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203930711.13162.46.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luisca@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox