* [PATCH] mac80211: add missing "break" statement in mesh code
@ 2008-02-25 9:11 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2008-02-25 9:11 UTC (permalink / raw)
To: John Linville; +Cc: Luis Carlos Cobo, linux-wireless
This inserts a missing break statement which, if hit, would cause
the code to fall-through and unlock a spinlock twice. Noticed via
sparse's "lock count wrong in basic block" warning and careful
code inspection.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Carlos Cobo <luisca@cozybit.com>
---
net/mac80211/mesh_plink.c | 1 +
1 file changed, 1 insertion(+)
--- everything.orig/net/mac80211/mesh_plink.c 2008-02-24 12:22:02.000000000 +0100
+++ everything/net/mac80211/mesh_plink.c 2008-02-24 12:22:18.000000000 +0100
@@ -691,6 +691,7 @@ void mesh_rx_plink_frame(struct net_devi
spin_unlock_bh(&sta->plink_lock);
mesh_plink_frame_tx(dev, PLINK_CLOSE, sta->addr, llid,
plid, reason);
+ break;
case OPN_ACPT:
if (del_timer(&sta->plink_timer))
sta_info_put(sta);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-25 9:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-25 9:11 [PATCH] mac80211: add missing "break" statement in mesh code Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox