* [PATCH] libertas: fix sanity check on sequence number in command response
@ 2008-03-03 11:20 Holger Schurig
2008-03-04 17:12 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Holger Schurig @ 2008-03-03 11:20 UTC (permalink / raw)
To: libertas-dev; +Cc: linux-wireless, John W. Linville, Dan Williams
From: David Woodhouse <dwmw2@infradead.org>
Slightly more useful if we compare it against the sequence number of the
command we have outstanding, rather than comparing the reply with itself.
Doh. Pointed out by Sebastian Siewior
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index e6b4b23..52d02f3 100644
--- a/drivers/net/wireless/libertas/cmdresp.c
+++ b/drivers/net/wireless/libertas/cmdresp.c
@@ -509,9 +509,9 @@ int lbs_process_rx_command(struct lbs_private *priv)
respcmd, le16_to_cpu(resp->seqnum), priv->upld_len, jiffies);
lbs_deb_hex(LBS_DEB_CMD, "CMD_RESP", (void *) resp, priv->upld_len);
- if (resp->seqnum != resp->seqnum) {
+ if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
lbs_pr_info("Received CMD_RESP with invalid sequence %d (expected %d)\n",
- le16_to_cpu(resp->seqnum), le16_to_cpu(resp->seqnum));
+ le16_to_cpu(resp->seqnum), le16_to_cpu(priv->cur_cmd->cmdbuf->seqnum));
spin_unlock_irqrestore(&priv->driver_lock, flags);
ret = -1;
goto done;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] libertas: fix sanity check on sequence number in command response
2008-03-03 11:20 [PATCH] libertas: fix sanity check on sequence number in command response Holger Schurig
@ 2008-03-04 17:12 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2008-03-04 17:12 UTC (permalink / raw)
To: Holger Schurig; +Cc: libertas-dev, linux-wireless, John W. Linville
On Mon, 2008-03-03 at 12:20 +0100, Holger Schurig wrote:
> From: David Woodhouse <dwmw2@infradead.org>
>
> Slightly more useful if we compare it against the sequence number of the
> command we have outstanding, rather than comparing the reply with itself.
>
> Doh. Pointed out by Sebastian Siewior
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Dan Williams <dcbw@redhat.com>
> diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
> index e6b4b23..52d02f3 100644
> --- a/drivers/net/wireless/libertas/cmdresp.c
> +++ b/drivers/net/wireless/libertas/cmdresp.c
> @@ -509,9 +509,9 @@ int lbs_process_rx_command(struct lbs_private *priv)
> respcmd, le16_to_cpu(resp->seqnum), priv->upld_len, jiffies);
> lbs_deb_hex(LBS_DEB_CMD, "CMD_RESP", (void *) resp, priv->upld_len);
>
> - if (resp->seqnum != resp->seqnum) {
> + if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
> lbs_pr_info("Received CMD_RESP with invalid sequence %d (expected %d)\n",
> - le16_to_cpu(resp->seqnum), le16_to_cpu(resp->seqnum));
> + le16_to_cpu(resp->seqnum), le16_to_cpu(priv->cur_cmd->cmdbuf->seqnum));
> spin_unlock_irqrestore(&priv->driver_lock, flags);
> ret = -1;
> goto done;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-04 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-03 11:20 [PATCH] libertas: fix sanity check on sequence number in command response Holger Schurig
2008-03-04 17:12 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox