Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] mac80211: filter scan results on unusable channels
@ 2008-03-16 17:42 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2008-03-16 17:42 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless, Jes Sorensen

When you have an AP on channel 13, it will currently often enough
be listed in scan results even when the regulatory domain restricts
to channels 1-11. This is due to channel overlap. To avoid getting
very strange failures, don't show such APs in the scan results. The
failure mode will now go from "I can see the AP but not associate"
to "I can't see the AP although I know it's there" which is easier
to debug.

This problem was first really noticed by Jes Sorensen.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Jes Sorensen <jes@trained-monkey.org>
---
Depends on the previous patch adding the ieee80211_get_channel function.

 net/mac80211/ieee80211_sta.c |    6 ++++++
 1 file changed, 6 insertions(+)

--- everything.orig/net/mac80211/ieee80211_sta.c	2008-03-16 18:17:24.000000000 +0100
+++ everything/net/mac80211/ieee80211_sta.c	2008-03-16 18:37:27.000000000 +0100
@@ -2356,6 +2356,7 @@ static void ieee80211_rx_bss_info(struct
 	struct sta_info *sta;
 	struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
 	u64 beacon_timestamp, rx_timestamp;
+	struct ieee80211_channel *channel;
 	DECLARE_MAC_BUF(mac);
 	DECLARE_MAC_BUF(mac2);
 
@@ -2420,6 +2421,11 @@ static void ieee80211_rx_bss_info(struct
 	else
 		freq = rx_status->freq;
 
+	channel = ieee80211_get_channel(local->hw.wiphy, freq);
+
+	if (!channel || channel->flags & IEEE80211_CHAN_DISABLED)
+		return;
+
 #ifdef CONFIG_MAC80211_MESH
 	if (elems.mesh_config)
 		bss = ieee80211_rx_mesh_bss_get(dev, elems.mesh_id,



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-16 17:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-16 17:42 [PATCH] mac80211: filter scan results on unusable channels Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox