From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: remove CMD_802_11_PWR_CFG
Date: Wed, 26 Mar 2008 10:17:31 -0400 [thread overview]
Message-ID: <1206541051.30998.11.camel@localhost.localdomain> (raw)
In-Reply-To: <200803260957.45917.hs4233@mail.mn-solutions.de>
On Wed, 2008-03-26 at 09:57 +0100, Holger Schurig wrote:
> This has nowhere been used. Note: in the firmware manual this was
> documented as CMD_802_11_PA_CFG. If we ever need it, we can/should
> re-implement it as a direct command.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> --- wireless-testing.orig/drivers/net/wireless/libertas/cmd.c
> +++ wireless-testing/drivers/net/wireless/libertas/cmd.c
> @@ -1453,16 +1453,6 @@
> break;
> }
>
> - case CMD_802_11_PWR_CFG:
> - cmdptr->command = cpu_to_le16(CMD_802_11_PWR_CFG);
> - cmdptr->size =
> - cpu_to_le16(sizeof(struct cmd_ds_802_11_pwr_cfg) +
> - S_DS_GEN);
> - memmove(&cmdptr->params.pwrcfg, pdata_buf,
> - sizeof(struct cmd_ds_802_11_pwr_cfg));
> -
> - ret = 0;
> - break;
> case CMD_BT_ACCESS:
> ret = lbs_cmd_bt_access(cmdptr, cmd_action, pdata_buf);
> break;
> --- wireless-testing.orig/drivers/net/wireless/libertas/cmdresp.c
> +++ wireless-testing/drivers/net/wireless/libertas/cmdresp.c
> @@ -312,14 +312,6 @@
> spin_unlock_irqrestore(&priv->driver_lock, flags);
> break;
>
> - case CMD_RET(CMD_802_11_PWR_CFG):
> - spin_lock_irqsave(&priv->driver_lock, flags);
> - memmove((void *)priv->cur_cmd->callback_arg, &resp->params.pwrcfg,
> - sizeof(struct cmd_ds_802_11_pwr_cfg));
> - spin_unlock_irqrestore(&priv->driver_lock, flags);
> -
> - break;
> -
> case CMD_RET(CMD_GET_TSF):
> spin_lock_irqsave(&priv->driver_lock, flags);
> memcpy((void *)priv->cur_cmd->callback_arg,
> --- wireless-testing.orig/drivers/net/wireless/libertas/host.h
> +++ wireless-testing/drivers/net/wireless/libertas/host.h
> @@ -84,7 +84,6 @@
> #define CMD_802_11_INACTIVITY_TIMEOUT 0x0067
> #define CMD_802_11_SLEEP_PERIOD 0x0068
> #define CMD_802_11_TPC_CFG 0x0072
> -#define CMD_802_11_PWR_CFG 0x0073
> #define CMD_802_11_FW_WAKE_METHOD 0x0074
> #define CMD_802_11_SUBSCRIBE_EVENT 0x0075
> #define CMD_802_11_RATE_ADAPT_RATESET 0x0076
> --- wireless-testing.orig/drivers/net/wireless/libertas/hostcmd.h
> +++ wireless-testing/drivers/net/wireless/libertas/hostcmd.h
> @@ -616,14 +616,6 @@
> u8 data[256];
> } __attribute__ ((packed));
>
> -struct cmd_ds_802_11_pwr_cfg {
> - __le16 action;
> - u8 enable;
> - s8 PA_P0;
> - s8 PA_P1;
> - s8 PA_P2;
> -} __attribute__ ((packed));
> -
> struct cmd_ds_802_11_afc {
> __le16 afc_auto;
> union {
> @@ -728,7 +720,6 @@
> struct cmd_ds_802_11d_domain_info domaininforesp;
>
> struct cmd_ds_802_11_tpc_cfg tpccfg;
> - struct cmd_ds_802_11_pwr_cfg pwrcfg;
> struct cmd_ds_802_11_afc afc;
> struct cmd_ds_802_11_led_ctrl ledgpio;
>
prev parent reply other threads:[~2008-03-26 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 8:57 [PATCH] libertas: remove CMD_802_11_PWR_CFG Holger Schurig
2008-03-26 14:17 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206541051.30998.11.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox