* [PATCH] libertas: remove CMD_802_11_PWR_CFG
@ 2008-03-26 8:57 Holger Schurig
2008-03-26 14:17 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Holger Schurig @ 2008-03-26 8:57 UTC (permalink / raw)
To: libertas-dev; +Cc: Dan Williams, linux-wireless, John W. Linville
This has nowhere been used. Note: in the firmware manual this was
documented as CMD_802_11_PA_CFG. If we ever need it, we can/should
re-implement it as a direct command.
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
--- wireless-testing.orig/drivers/net/wireless/libertas/cmd.c
+++ wireless-testing/drivers/net/wireless/libertas/cmd.c
@@ -1453,16 +1453,6 @@
break;
}
- case CMD_802_11_PWR_CFG:
- cmdptr->command = cpu_to_le16(CMD_802_11_PWR_CFG);
- cmdptr->size =
- cpu_to_le16(sizeof(struct cmd_ds_802_11_pwr_cfg) +
- S_DS_GEN);
- memmove(&cmdptr->params.pwrcfg, pdata_buf,
- sizeof(struct cmd_ds_802_11_pwr_cfg));
-
- ret = 0;
- break;
case CMD_BT_ACCESS:
ret = lbs_cmd_bt_access(cmdptr, cmd_action, pdata_buf);
break;
--- wireless-testing.orig/drivers/net/wireless/libertas/cmdresp.c
+++ wireless-testing/drivers/net/wireless/libertas/cmdresp.c
@@ -312,14 +312,6 @@
spin_unlock_irqrestore(&priv->driver_lock, flags);
break;
- case CMD_RET(CMD_802_11_PWR_CFG):
- spin_lock_irqsave(&priv->driver_lock, flags);
- memmove((void *)priv->cur_cmd->callback_arg, &resp->params.pwrcfg,
- sizeof(struct cmd_ds_802_11_pwr_cfg));
- spin_unlock_irqrestore(&priv->driver_lock, flags);
-
- break;
-
case CMD_RET(CMD_GET_TSF):
spin_lock_irqsave(&priv->driver_lock, flags);
memcpy((void *)priv->cur_cmd->callback_arg,
--- wireless-testing.orig/drivers/net/wireless/libertas/host.h
+++ wireless-testing/drivers/net/wireless/libertas/host.h
@@ -84,7 +84,6 @@
#define CMD_802_11_INACTIVITY_TIMEOUT 0x0067
#define CMD_802_11_SLEEP_PERIOD 0x0068
#define CMD_802_11_TPC_CFG 0x0072
-#define CMD_802_11_PWR_CFG 0x0073
#define CMD_802_11_FW_WAKE_METHOD 0x0074
#define CMD_802_11_SUBSCRIBE_EVENT 0x0075
#define CMD_802_11_RATE_ADAPT_RATESET 0x0076
--- wireless-testing.orig/drivers/net/wireless/libertas/hostcmd.h
+++ wireless-testing/drivers/net/wireless/libertas/hostcmd.h
@@ -616,14 +616,6 @@
u8 data[256];
} __attribute__ ((packed));
-struct cmd_ds_802_11_pwr_cfg {
- __le16 action;
- u8 enable;
- s8 PA_P0;
- s8 PA_P1;
- s8 PA_P2;
-} __attribute__ ((packed));
-
struct cmd_ds_802_11_afc {
__le16 afc_auto;
union {
@@ -728,7 +720,6 @@
struct cmd_ds_802_11d_domain_info domaininforesp;
struct cmd_ds_802_11_tpc_cfg tpccfg;
- struct cmd_ds_802_11_pwr_cfg pwrcfg;
struct cmd_ds_802_11_afc afc;
struct cmd_ds_802_11_led_ctrl ledgpio;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] libertas: remove CMD_802_11_PWR_CFG
2008-03-26 8:57 [PATCH] libertas: remove CMD_802_11_PWR_CFG Holger Schurig
@ 2008-03-26 14:17 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2008-03-26 14:17 UTC (permalink / raw)
To: Holger Schurig; +Cc: libertas-dev, linux-wireless, John W. Linville
On Wed, 2008-03-26 at 09:57 +0100, Holger Schurig wrote:
> This has nowhere been used. Note: in the firmware manual this was
> documented as CMD_802_11_PA_CFG. If we ever need it, we can/should
> re-implement it as a direct command.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> --- wireless-testing.orig/drivers/net/wireless/libertas/cmd.c
> +++ wireless-testing/drivers/net/wireless/libertas/cmd.c
> @@ -1453,16 +1453,6 @@
> break;
> }
>
> - case CMD_802_11_PWR_CFG:
> - cmdptr->command = cpu_to_le16(CMD_802_11_PWR_CFG);
> - cmdptr->size =
> - cpu_to_le16(sizeof(struct cmd_ds_802_11_pwr_cfg) +
> - S_DS_GEN);
> - memmove(&cmdptr->params.pwrcfg, pdata_buf,
> - sizeof(struct cmd_ds_802_11_pwr_cfg));
> -
> - ret = 0;
> - break;
> case CMD_BT_ACCESS:
> ret = lbs_cmd_bt_access(cmdptr, cmd_action, pdata_buf);
> break;
> --- wireless-testing.orig/drivers/net/wireless/libertas/cmdresp.c
> +++ wireless-testing/drivers/net/wireless/libertas/cmdresp.c
> @@ -312,14 +312,6 @@
> spin_unlock_irqrestore(&priv->driver_lock, flags);
> break;
>
> - case CMD_RET(CMD_802_11_PWR_CFG):
> - spin_lock_irqsave(&priv->driver_lock, flags);
> - memmove((void *)priv->cur_cmd->callback_arg, &resp->params.pwrcfg,
> - sizeof(struct cmd_ds_802_11_pwr_cfg));
> - spin_unlock_irqrestore(&priv->driver_lock, flags);
> -
> - break;
> -
> case CMD_RET(CMD_GET_TSF):
> spin_lock_irqsave(&priv->driver_lock, flags);
> memcpy((void *)priv->cur_cmd->callback_arg,
> --- wireless-testing.orig/drivers/net/wireless/libertas/host.h
> +++ wireless-testing/drivers/net/wireless/libertas/host.h
> @@ -84,7 +84,6 @@
> #define CMD_802_11_INACTIVITY_TIMEOUT 0x0067
> #define CMD_802_11_SLEEP_PERIOD 0x0068
> #define CMD_802_11_TPC_CFG 0x0072
> -#define CMD_802_11_PWR_CFG 0x0073
> #define CMD_802_11_FW_WAKE_METHOD 0x0074
> #define CMD_802_11_SUBSCRIBE_EVENT 0x0075
> #define CMD_802_11_RATE_ADAPT_RATESET 0x0076
> --- wireless-testing.orig/drivers/net/wireless/libertas/hostcmd.h
> +++ wireless-testing/drivers/net/wireless/libertas/hostcmd.h
> @@ -616,14 +616,6 @@
> u8 data[256];
> } __attribute__ ((packed));
>
> -struct cmd_ds_802_11_pwr_cfg {
> - __le16 action;
> - u8 enable;
> - s8 PA_P0;
> - s8 PA_P1;
> - s8 PA_P2;
> -} __attribute__ ((packed));
> -
> struct cmd_ds_802_11_afc {
> __le16 afc_auto;
> union {
> @@ -728,7 +720,6 @@
> struct cmd_ds_802_11d_domain_info domaininforesp;
>
> struct cmd_ds_802_11_tpc_cfg tpccfg;
> - struct cmd_ds_802_11_pwr_cfg pwrcfg;
> struct cmd_ds_802_11_afc afc;
> struct cmd_ds_802_11_led_ctrl ledgpio;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-26 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-26 8:57 [PATCH] libertas: remove CMD_802_11_PWR_CFG Holger Schurig
2008-03-26 14:17 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox