Re: [PATCH 2/2] mac80211: 11h - Handling measurement request

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]


> >> +     msr_report->u.action.u.measurement.msr_elem.token = request_ie->token;
> >> +     msr_report->u.action.u.measurement.msr_elem.mode |= MSR_REPORT_REFUSED;
> >
> > Also, it seems to me that should be part of the arguments or you won't
> > be able to use this function for anything else but sending a 'refused'
> > report?
> 
> Don't mind to put it into arguments, just the argument list have to be alter
> anyway if real measurement is performed and results need to be sent out.

Yeah, true. Or you can just call the function
_refuse_measurement_request() instead.

> >> +/* measurement report mode field - refuse to generate a report */
> >> +#define MSR_REPORT_REFUSED       BIT(2)
> >
> > That seems completely misplaced in sta_info.h to me?
> 
> Yep will move it to
> include/linux/ieee80211.h ?

Sounds appropriate, though it should probably be renamed then to have a
proper IEEE80211 prefix. Are there other items in that field you might
want to collect into an enum? Doesn't matter much to me though, one can
always look it up in the spec.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]