Re: [PATCH 2/2] mac80211: 11h - Handling measurement request

["Tomas Winkler" <tomasw@gmail.com>]

On Mon, Jun 16, 2008 at 11:41 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
>> This patch handles the 11h measurement request information element.
>> This is minimal requested implementation - refuse measurement.
>
> I haven't really read 11h or the -2007 wrt. the added material, but this
> seems a bit odd to me:
>
>> +static void ieee80211_send_measurement_req(struct net_device *dev,
>> +                             struct ieee80211_msrment_ie *request_ie,
>> +                             const u8 *da, const u8 *bssid,
>> +                             u8 dialog_token)
>
>> +     msr_report->u.action.u.measurement.element_id = WLAN_EID_MEASURE_REPORT;
>
> It's sending a report after all, not a request. Maybe it should just be
> named "send_measurement_action"?

Will do.

>
>> +     msr_report->u.action.u.measurement.msr_elem.token = request_ie->token;
>> +     msr_report->u.action.u.measurement.msr_elem.mode |= MSR_REPORT_REFUSED;
>
> Also, it seems to me that should be part of the arguments or you won't
> be able to use this function for anything else but sending a 'refused'
> report?

Don't mind to put it into arguments, just the argument list have to be alter
anyway if real measurement is performed and results need to be sent out.
 Currently no plans to implement  more then necessary minimum to
comply with the spec.


>
>> +/* measurement report mode field - refuse to generate a report */
>> +#define MSR_REPORT_REFUSED       BIT(2)
>
> That seems completely misplaced in sta_info.h to me?

Yep will move it to
include/linux/ieee80211.h ?

Thanks
Tomas