Re: [PATCH 2/2] mac80211: add spectrum capabilities

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On Wed, 2008-06-18 at 17:53 +0300, Tomas Winkler wrote:
> This patch add spectrum capability and required information
> elements to association request providing AP has requested it and
> it is supported by the driver

Why bother splitting this up into two patches, the Kconfig option isn't
even being used?

> +		if ((bss->capability & WLAN_CAPABILITY_SPECTRUM_MGMT) &&
> +		    (local->hw.flags & IEEE80211_HW_SPECTRUM_MGMT))
> +			capab |= WLAN_CAPABILITY_SPECTRUM_MGMT;

Why do we need a hardware capability flag for this? The only thing you
seem to be doing with it is determine whether to send the power
capability IE?

Will you follow up with more patches to enable radar detection and
things like that, and shouldn't we merge that as one series? This looks
sane enough, but it seems hard to judge whether or not it's actually the
best way to do things.

What else will depend on the hw capability flag?

[and yes, I should read 11h/-2007 again]

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]