From: Johannes Berg <johannes@sipsolutions.net>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 3/2] get rid of rx handler function pointers
Date: Thu, 19 Jun 2008 19:24:49 +0200 [thread overview]
Message-ID: <1213896290.8967.39.camel@johannes.berg> (raw)
In-Reply-To: <1213896016.2125.51.camel@brick> (sfid-20080619_192022_768705_8A43D8D3)
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
> > #define CALL_RXH(rxh) if ((res = rxh(rx)) != RX_CONTINUE) goto rxh_done;
>
> Would it really be so bad to just open-code them rather than the macro approach?
>
> res = ieee80211_rx_h_passive_scan(rx);
> if (res != RX_CONTINUE) goto rxh_done;
>
> res = ieee80211_rx_h_check(rx);
> if (res != RX_CONTINUE) goto rxh_done;
>
> ...
>
>
> Similar comment for the transmit handler patch.
Well, I was lazy, and figured it'd be easier to add new ones that way if
needed.
> Either way, the approach looks good,
> and the size reduction is nice.
:)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-06-19 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 12:38 [RFC 3/2] get rid of rx handler function pointers Johannes Berg
2008-06-19 17:20 ` Harvey Harrison
2008-06-19 17:24 ` Johannes Berg [this message]
2008-06-19 17:44 ` Michael Buesch
2008-06-19 17:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213896290.8967.39.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox