Re: Broken fragmentation

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Wed, 2008-06-25 at 12:50 +0300, Tomas Winkler wrote:
> On Fri, Jun 20, 2008 at 12:25 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> >
> >> >> Fragments are in the air but the peer is not able to reassemble them.
> >> >> Something is wrong with the first fragment but I'm not sure yet.
> >> >
> >> > Hm, ok. got a packet capture? Maybe that was broken before, I remember
> >> > having problems with fragmentation but putting it down to the
> >> > known-to-be-completely-broken AP I was using.
> >>
> >> It is working the latest problem was caused by the driver, Yet i still
> >> don't understand the regression
> >> in the driver.
> >
> > Hmm, ok.
> >
> So the bug is still in mac80211. Fragments are scheduled to different
> TIDs and hence to different queues.
> Investigating further. If you have something in mind let me know

Hmm, yes, I do indeed, try

skb_copy_queue_mapping(frag, first);

where you previously added the cb copy.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]