From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Linux Wireless" <linux-wireless@vger.kernel.org>
Subject: Broken fragmentation
Date: Thu, 19 Jun 2008 12:20:24 +0300 [thread overview]
Message-ID: <1ba2fa240806190220l18fe5dcdsf44fe81412a5f35d@mail.gmail.com> (raw)
Johannes
Your patch bellow has broken the fragmentation. Can you please have a
look at this.
commit 49cfd9a35cd593e3b575b89c2dca148bdd4fbb57
Author: Johannes Berg <johannes@sipsolutions.net>
Date: Thu May 15 12:55:28 2008 +0200
mac80211: reorder some transmit handlers
static ieee80211_tx_handler ieee80211_tx_handlers[] =
{
ieee80211_tx_h_check_assoc,
ieee80211_tx_h_sequence,
ieee80211_tx_h_ps_buf,
ieee80211_tx_h_select_key,
ieee80211_tx_h_michael_mic_add,
ieee80211_tx_h_rate_ctrl,
ieee80211_tx_h_misc, -- this
one already assume fragmetation
ieee80211_tx_h_fragment,
/* handlers after fragment must be aware of tx info fragmentation! */
ieee80211_tx_h_encrypt,
ieee80211_tx_h_stats,
NULL
};
static ieee80211_tx_result
ieee80211_tx_h_misc(struct ieee80211_tx_data *tx)
{
/* Setup duration field for the first fragment of the frame. Duration
* for remaining fragments will be updated when they are being sent
* to low-level driver in ieee80211_tx(). */
dur = ieee80211_duration(tx, is_multicast_ether_addr(hdr->addr1),
(tx->flags & IEEE80211_TX_FRAGMENTED) ?
tx->extra_frag[0]->len : 0); --
NULL pointer
}
Thanks
Tomas
next reply other threads:[~2008-06-19 9:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 9:20 Tomas Winkler [this message]
2008-06-19 9:56 ` Broken fragmentation Johannes Berg
2008-06-19 11:46 ` Tomas Winkler
2008-06-19 11:57 ` Tomas Winkler
2008-06-19 12:23 ` Johannes Berg
2008-06-19 13:08 ` Tomas Winkler
2008-06-19 13:24 ` Johannes Berg
2008-06-19 14:45 ` Tomas Winkler
2008-06-19 15:26 ` Johannes Berg
2008-06-19 18:13 ` Tomas Winkler
2008-06-19 18:16 ` Johannes Berg
2008-06-19 21:09 ` Tomas Winkler
2008-06-19 21:25 ` Johannes Berg
2008-06-25 9:50 ` Tomas Winkler
2008-06-25 10:02 ` Johannes Berg
2008-06-25 10:30 ` Tomas Winkler
2008-06-25 10:32 ` Johannes Berg
2008-06-25 10:35 ` Tomas Winkler
2008-06-25 10:42 ` Johannes Berg
2008-06-25 10:59 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240806190220l18fe5dcdsf44fe81412a5f35d@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox