From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomasw@gmail.com>
Cc: drago01 <drago01@gmail.com>,
linville@tuxdriver.com, yi.zhu@intel.com,
linux-wireless@vger.kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH 1/1] mac80211: don't accept WEP keys other than WEP40 and WEP104
Date: Mon, 30 Jun 2008 11:25:05 +0200 [thread overview]
Message-ID: <1214817905.5507.29.camel@johannes.berg> (raw)
In-Reply-To: <1ba2fa240806290257r1db0e021n152945d41ffe2f42@mail.gmail.com> (sfid-20080629_115722_351612_5A52EE51)
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
> > I don't think zero-keylen will have WEP there, will it? I don't really
> > know though.
>
> This patch pushes the length check to ieee80211_set_encryption.
> Unlike John's patch
> where check was done in ieee80211_ioctl_siwencode.
> The benefit of this is that both ENCODE end ENCODEEXT are treated.
> The zero length key i.e. changing index is already taken care of in
> ieee80211_ioctl_siwencode
Alright, thanks for the explanation.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-06-30 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 23:50 [PATCH 1/1] mac80211: don't accept WEP keys other than WEP40 and WEP104 Tomas Winkler
2008-06-28 6:46 ` drago01
2008-06-28 7:57 ` Johannes Berg
2008-06-29 9:57 ` Tomas Winkler
2008-06-30 9:25 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214817905.5507.29.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=drago01@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomasw@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox